You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/24 10:16:01 UTC

[GitHub] [incubator-shenyu] dragon-zhang opened a new pull request, #3615: [ISSUE #3614] admin delay update handle in selector

dragon-zhang opened a new pull request, #3615:
URL: https://github.com/apache/incubator-shenyu/pull/3615

   Fixes #3614 
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-shenyu] yu199195 merged pull request #3615: [ISSUE #3614] admin delay update handle in selector

Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #3615:
URL: https://github.com/apache/incubator-shenyu/pull/3615


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3615: [ISSUE #3614] admin delay update handle in selector

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3615:
URL: https://github.com/apache/incubator-shenyu/pull/3615#issuecomment-1165457775

   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3615?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3615](https://codecov.io/gh/apache/incubator-shenyu/pull/3615?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (069cd60) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/2780c1f7bfa65fcba96b2b4ca7e56c0911a79cfb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2780c1f) will **increase** coverage by `0.06%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3615      +/-   ##
   ============================================
   + Coverage     62.55%   62.61%   +0.06%     
   - Complexity     5718     5723       +5     
   ============================================
     Files           869      869              
     Lines         24147    24147              
     Branches       2206     2203       -3     
   ============================================
   + Hits          15105    15120      +15     
   + Misses         7640     7624      -16     
   - Partials       1402     1403       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `65.30% <0.00%> (-1.37%)` | :arrow_down: |
   | [...ister/AbstractShenyuClientRegisterServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9yZWdpc3Rlci9BYnN0cmFjdFNoZW55dUNsaWVudFJlZ2lzdGVyU2VydmljZUltcGwuamF2YQ==) | `3.77% <0.00%> (ø)` | |
   | [...t/apache/dubbo/ApacheDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvY2xpZW50L2FwYWNoZS9kdWJiby9BcGFjaGVEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...alibaba/dubbo/AlibabaDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9hbGliYWJhL2R1YmJvL0FsaWJhYmFEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ringcloud/init/SpringCloudClientEventListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L1NwcmluZ0Nsb3VkQ2xpZW50RXZlbnRMaXN0ZW5lci5qYXZh) | `57.30% <0.00%> (+0.63%)` | :arrow_up: |
   | [.../plugin/grpc/loadbalance/AbstractLoadBalancer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9sb2FkYmFsYW5jZS9BYnN0cmFjdExvYWRCYWxhbmNlci5qYXZh) | `78.26% <0.00%> (+7.60%)` | :arrow_up: |
   | [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `72.34% <0.00%> (+8.51%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3615?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3615?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2780c1f...069cd60](https://codecov.io/gh/apache/incubator-shenyu/pull/3615?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org