You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/07/29 16:58:14 UTC

Review Request 50607: Update of cq stats causing disk read

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50607/
-----------------------------------------------------------

Review request for geode, anilkumar gingade, Bruce Schuchardt, and Dan Smith.


Repository: geode


Description
-------

This test verifies perf of durable client -queue with overflow. In case of overflow client queue uses LIFO policy. Because of that we put new entry on disk first. But, after putting that entry into queue that thread needs to update Cq stats, which causes that thread to fetch that value again from disk. that hurts performance. we should be updating any(all) client stats before putting that value into disk.

Using "hw.getClientUpdateMessage()" to update the stats..


Diffs
-----

  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java c5746ed 

Diff: https://reviews.apache.org/r/50607/diff/


Testing
-------


Thanks,

Hitesh Khamesra

Re: Review Request 50607: Update of cq stats causing disk read

Posted by Bruce Schuchardt <bs...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50607/#review144124
-----------------------------------------------------------


Ship it!




Ship It!

- Bruce Schuchardt


On July 29, 2016, 4:58 p.m., Hitesh Khamesra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50607/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 4:58 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Bruce Schuchardt, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This test verifies perf of durable client -queue with overflow. In case of overflow client queue uses LIFO policy. Because of that we put new entry on disk first. But, after putting that entry into queue that thread needs to update Cq stats, which causes that thread to fetch that value again from disk. that hurts performance. we should be updating any(all) client stats before putting that value into disk.
> 
> Using "hw.getClientUpdateMessage()" to update the stats..
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java c5746ed 
> 
> Diff: https://reviews.apache.org/r/50607/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>