You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/24 17:26:00 UTC

[jira] [Commented] (DRILL-6282) Excluding io.dropwizard.metrics dependencies

    [ https://issues.apache.org/jira/browse/DRILL-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450257#comment-16450257 ] 

ASF GitHub Bot commented on DRILL-6282:
---------------------------------------

Github user vdiravka commented on the issue:

    https://github.com/apache/drill/pull/1189
  
    @vrozov I have replaced `com.codahale.metrics` with last `io.dropwizard.metrics`. 
    Please review.


> Excluding io.dropwizard.metrics dependencies
> --------------------------------------------
>
>                 Key: DRILL-6282
>                 URL: https://issues.apache.org/jira/browse/DRILL-6282
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build &amp; Test
>    Affects Versions: 1.13.0
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>            Priority: Major
>             Fix For: 1.14.0
>
>
> There are three types of metrics-core in Drill: 
> 1. _com.yammer.metrics_, 
> 2. _com.codahale.metrics_, 
> 3. _io.dropwizard.metrics_
> Drill uses only 1 and 2. The last 3 one is used by Hive.
> 1st one has different class full identifiers, but the 2 and 3 ones have the same class full identifiers and maven doesn't know which library to use ([https://github.com/dropwizard/metrics/issues/1044]).
> But I found that 3 one library is used by Hive only for tests, therefore it is not required for Drill and could be excluded from hive-metastore and hive-exec.
> The dependencies conflict is related not only to metrics-core, but to metrics-servlets and metrics-json as well.
> All these metrics should be organized with proper excluding and dependency management blocks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)