You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/10 17:56:17 UTC
[GitHub] [camel] orpiske opened a new pull request #6419: CAMEL-17121: final cleanups
orpiske opened a new pull request #6419:
URL: https://github.com/apache/camel/pull/6419
- Added documentation details
- Fixed typos
- Fixed/improved log messages
- Used final for a few variables
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a change in pull request #6419: CAMEL-17121: final cleanups
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #6419:
URL: https://github.com/apache/camel/pull/6419#discussion_r747248099
##########
File path: core/camel-support/src/main/java/org/apache/camel/support/task/BackgroundTask.java
##########
@@ -155,7 +155,7 @@ private boolean waitForTaskCompletion(CountDownLatch latch, ScheduledExecutorSer
if (!latch.await(budget.maxDuration(), TimeUnit.MILLISECONDS)) {
LOG.debug("Timeout out waiting for the completion of the task");
} else {
- LOG.info("The task is complete after iterations and the code is ready to continue");
+ LOG.info("The task has finished the execution is ready to continue");
Review comment:
Done, marking as resolved, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a change in pull request #6419: CAMEL-17121: final cleanups
Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #6419:
URL: https://github.com/apache/camel/pull/6419#discussion_r747246510
##########
File path: core/camel-support/src/main/java/org/apache/camel/support/task/BackgroundTask.java
##########
@@ -155,7 +155,7 @@ private boolean waitForTaskCompletion(CountDownLatch latch, ScheduledExecutorSer
if (!latch.await(budget.maxDuration(), TimeUnit.MILLISECONDS)) {
LOG.debug("Timeout out waiting for the completion of the task");
} else {
- LOG.info("The task is complete after iterations and the code is ready to continue");
+ LOG.info("The task has finished the execution is ready to continue");
Review comment:
Sure thing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #6419: CAMEL-17121: final cleanups
Posted by GitBox <gi...@apache.org>.
orpiske merged pull request #6419:
URL: https://github.com/apache/camel/pull/6419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #6419: CAMEL-17121: final cleanups
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #6419:
URL: https://github.com/apache/camel/pull/6419#discussion_r747246185
##########
File path: core/camel-support/src/main/java/org/apache/camel/support/task/BackgroundTask.java
##########
@@ -155,7 +155,7 @@ private boolean waitForTaskCompletion(CountDownLatch latch, ScheduledExecutorSer
if (!latch.await(budget.maxDuration(), TimeUnit.MILLISECONDS)) {
LOG.debug("Timeout out waiting for the completion of the task");
} else {
- LOG.info("The task is complete after iterations and the code is ready to continue");
+ LOG.info("The task has finished the execution is ready to continue");
Review comment:
Use DEBUG logging level as we should not be noisy during processing exchanges in Camel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org