You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:34:00 UTC
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #397: Make Azure data disk config names consistent
karthick-rn commented on a change in pull request #397:
URL: https://github.com/apache/fluo-muchos/pull/397#discussion_r649885295
##########
File path: lib/muchos/config/azure.py
##########
@@ -297,15 +297,15 @@ def azure_proxy_host(self):
return self.get("azure", "azure_proxy_host")
@ansible_host_var
- @default(None)
+ @default("Standard_D8s_v3")
def azure_proxy_host_vm_sku(self):
return self.get("azure", "azure_proxy_host_vm_sku")
Review comment:
Do we not want to add this property to the `muchos.props` file?
##########
File path: lib/muchos/config/azure.py
##########
@@ -297,15 +297,15 @@ def azure_proxy_host(self):
return self.get("azure", "azure_proxy_host")
@ansible_host_var
- @default(None)
+ @default("Standard_D8s_v3")
def azure_proxy_host_vm_sku(self):
return self.get("azure", "azure_proxy_host_vm_sku")
Review comment:
Do we not want to add this property to the `muchos.props` file?
##########
File path: lib/muchos/config/azure.py
##########
@@ -297,15 +297,15 @@ def azure_proxy_host(self):
return self.get("azure", "azure_proxy_host")
@ansible_host_var
- @default(None)
+ @default("Standard_D8s_v3")
def azure_proxy_host_vm_sku(self):
return self.get("azure", "azure_proxy_host_vm_sku")
Review comment:
Do we not want to add this property to the `muchos.props.example` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org