You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2006/04/30 13:56:22 UTC
svn commit: r398318 -
/jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java
Author: sebb
Date: Sun Apr 30 04:56:21 2006
New Revision: 398318
URL: http://svn.apache.org/viewcvs?rev=398318&view=rev
Log:
Use writeitem() to save the URL
Modified:
jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java
Modified: jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java
URL: http://svn.apache.org/viewcvs/jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java?rev=398318&r1=398317&r2=398318&view=diff
==============================================================================
--- jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java (original)
+++ jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java Sun Apr 30 04:56:21 2006
@@ -119,12 +119,6 @@
saveRequestHeaders(writer, context, res, save);
saveResponseData(writer, context, res, save);
saveSamplerData(writer, context, res, save);
- if (save.saveUrl()) {
- URL url = res.getURL();
- if (url != null) {
- writeString(writer, TAG_URL, url.toExternalForm());
- }
- }
}
/**
@@ -137,6 +131,9 @@
if (save.saveSamplerData(res)) {
writeString(writer, TAG_SAMPLER_DATA, res.getSamplerData());
}
+ if (save.saveUrl()) {
+ writeItem(res.getURL(), context, writer);
+ }
}
/**
@@ -296,9 +293,11 @@
}
/**
+ *
* @param reader
* @param context
* @param res
+ * @return true if the item was processed (for HTTPResultConverter)
*/
protected boolean retrieveItem(HierarchicalStreamReader reader, UnmarshallingContext context, SampleResult res,
Object subItem) {
@@ -321,7 +320,7 @@
res.setSamplerData((String) subItem);
} else if (nodeName.equals(TAG_RESPONSE_FILE)) {
res.setResultFileName((String) subItem);
- // Don't try restoring the URL
+ // Don't try restoring the URL TODO: wy not?
} else {
return false;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org