You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by EreMaijala <gi...@git.apache.org> on 2016/10/17 07:40:06 UTC
[GitHub] lucene-solr pull request #98: SOLR-9644: Fix boost handling in SimpleMLTQPar...
GitHub user EreMaijala opened a pull request:
https://github.com/apache/lucene-solr/pull/98
SOLR-9644: Fix boost handling in SimpleMLTQParser and CloudMLTQParser.
Both parsers tried to handle field boosts but didn't do it properly. This pull request includes the following changes to both:
- Parse boosts from qf even if boost=false to avoid errors.
- Use the field names from the boost parsing so that they are always clean.
- Add tests for the same query with and without boosting.
Also fixed is an additional problem in CloudMLTQParser where it added IndexableField type fields to the filtered document as is, which caused the document to include field definition strings such as "stored" and "indexed". This caused the MLT query to return records including these terms under some circumstances.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/EreMaijala/lucene-solr master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit 70ad5ccbb4a5b39b16f41c58dd5ee058811b6d9c
Author: Ere Maijala <er...@helsinki.fi>
Date: 2016-10-17T07:02:40Z
SOLR-9644 Fixed SimpleMLTQParser and CloudMLTQParser to handle boosts properly and CloudMLTQParser to only extract actual values from IndexableField type fields to the filtered document.
commit e10b9385df5c3183e80ed084fa48b0c4da9dd476
Author: Ere Maijala <er...@helsinki.fi>
Date: 2016-10-17T07:30:36Z
Improved the SimpleMLTQParserTest test case so that it actually shows a difference in results when boosting is used.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #98: SOLR-9644: Fix boost handling in SimpleMLTQParser and...
Posted by EreMaijala <gi...@git.apache.org>.
Github user EreMaijala commented on the issue:
https://github.com/apache/lucene-solr/pull/98
Note also that the old boost test cases were pretty useless, but I left them untouched to make sure their results are not affected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: distributed expand=true&fl=key NPE fix, ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucene-solr/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #98: SOLR-9644: Fix boost handling in SimpleMLTQParser and...
Posted by EreMaijala <gi...@git.apache.org>.
Github user EreMaijala commented on the issue:
https://github.com/apache/lucene-solr/pull/98
This should apply cleanly to branch_6x too (apart from CHANGES.txt obviously).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #98: SOLR-9644: Fix boost handling in SimpleMLTQParser and...
Posted by EreMaijala <gi...@git.apache.org>.
Github user EreMaijala commented on the issue:
https://github.com/apache/lucene-solr/pull/98
Closing this pull request and continuing with traditional patches in the JIRA issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #98: SOLR-9644: Fix boost handling in SimpleMLTQPar...
Posted by EreMaijala <gi...@git.apache.org>.
Github user EreMaijala closed the pull request at:
https://github.com/apache/lucene-solr/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org