[GitHub] [accumulo] keith-turner commented on a diff in pull request #3080: Remove deprecated replication

[GitBox <gi...@apache.org>]

keith-turner commented on code in PR #3080:
URL: https://github.com/apache/accumulo/pull/3080#discussion_r1027338656


##########
core/src/main/java/org/apache/accumulo/core/data/Mutation.java:
##########
@@ -1501,42 +1491,36 @@ public int size() {
   }
 
   /**
-   * Add a new element to the set of peers which this Mutation originated from
+   * Non-functional API; do not use
    *
-   * @param peer
-   *          the peer to add
    * @since 1.7.0
+   * @deprecated old, no longer functional API for replication feature removed in 3.0
    */
+  @Deprecated(since = "3.0.0")

Review Comment:
   I also like removing the method since it results in a compile time error instead of a run time one as others have mentioned.  Personally I like semver because when followed it usually means users have less minutiae they have to know to correctly use a project.  Following semver in this case seems like it would add minutia.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org