You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/22 17:45:18 UTC
[GitHub] [incubator-mxnet] kpuatamazon opened a new pull request #19407: [LICENSE] [v1.x] Change intgemm to a submodule instead of fetch.
kpuatamazon opened a new pull request #19407:
URL: https://github.com/apache/incubator-mxnet/pull/19407
## Description ##
This resolves the issue that `LICENSE` referred to `3rdparty/intgemm/LICENSE` which was not present in the source because it was downloaded:
https://lists.apache.org/thread.html/r669576b6506f67ea96e9b1bd385b04f59c4e6e7fa1b13a6dc0abc7d9%40%3Cgeneral.incubator.apache.org%3E
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [x] Remove fetch from `CMakeLists.txt`
- [x] Add submodule in `3rdparty`
- [x] Mention catch in top-level LICENSE
- [x] Exclude intgemm from header license checks
### Note ###
Sibling #19406 addresses v1.8.x. This is v1.x. master is coming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] kpuatamazon commented on pull request #19407: [LICENSE] [v1.x] Change intgemm to a submodule instead of fetch.
Posted by GitBox <gi...@apache.org>.
kpuatamazon commented on pull request #19407:
URL: https://github.com/apache/incubator-mxnet/pull/19407#issuecomment-714759290
@mxnet-bot run ci [unix-cpu, unix-gpu]
Testing is really flaky today https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-19407/1/pipeline
```
[2020-10-22T20:01:24.591Z] ======================================================================
[2020-10-22T20:01:24.591Z] FAIL: test operators which don't implement FComputeEx or FStatefulComputeEx
[2020-10-22T20:01:24.591Z] ----------------------------------------------------------------------
[2020-10-22T20:01:24.591Z] Traceback (most recent call last):
[2020-10-22T20:01:24.591Z] File "/usr/local/lib/python3.5/dist-packages/nose/case.py", line 198, in runTest
[2020-10-22T20:01:24.591Z] self.test(*self.arg)
[2020-10-22T20:01:24.591Z] File "/usr/local/lib/python3.5/dist-packages/nose/util.py", line 620, in newfunc
[2020-10-22T20:01:24.591Z] return func(*arg, **kw)
[2020-10-22T20:01:24.591Z] File "/work/mxnet/tests/python/gpu/../unittest/common.py", line 218, in test_new
[2020-10-22T20:01:24.591Z] orig_test(*args, **kwargs)
[2020-10-22T20:01:24.591Z] File "/work/mxnet/tests/python/gpu/../unittest/test_sparse_operator.py", line 1757, in test_sparse_storage_fallback
[2020-10-22T20:01:24.591Z] check_operator_with_temp_resource(shape, lhs)
[2020-10-22T20:01:24.591Z] File "/work/mxnet/tests/python/gpu/../unittest/test_sparse_operator.py", line 1752, in check_operator_with_temp_resource
[2020-10-22T20:01:24.591Z] check_numeric_gradient(test, location)
[2020-10-22T20:01:24.591Z] File "/work/mxnet/python/mxnet/test_utils.py", line 1238, in check_numeric_gradient
[2020-10-22T20:01:24.591Z] ("NUMERICAL_%s"%name, "BACKWARD_%s"%name))
[2020-10-22T20:01:24.591Z] File "/work/mxnet/python/mxnet/test_utils.py", line 749, in assert_almost_equal
[2020-10-22T20:01:24.591Z] raise AssertionError(msg)
[2020-10-22T20:01:24.591Z] AssertionError:
[2020-10-22T20:01:24.591Z] Items are not equal:
[2020-10-22T20:01:24.591Z] Error 1.254846 exceeds tolerance rtol=1.000000e-04, atol=1.000000e-03 (mismatch at least 11.000000%).
[2020-10-22T20:01:24.591Z] Location of maximum error: (0, 0), NUMERICAL_x=0.82617188, BACKWARD_x=0.82753056
[2020-10-22T20:01:24.591Z] ACTUAL: array([[0.8261719, 0.8261719, 0.8261719, ..., 0.8261719, 0.8261719,
[2020-10-22T20:01:24.591Z] 0.8261719],
[2020-10-22T20:01:24.591Z] [0.8261719, 0.8261719, 0.8261719, ..., 0.8261719, 0.8261719,...
[2020-10-22T20:01:24.591Z] DESIRED: array([[0.82753056, 0.82753056, 0.82753056, ..., 0.82753056, 0.82753056,
[2020-10-22T20:01:24.591Z] 0.82753056],
[2020-10-22T20:01:24.591Z] [0.82753056, 0.82753056, 0.82753056, ..., 0.82753056, 0.82753056,...
[2020-10-22T20:01:24.591Z] -------------------- >> begin captured stdout << ---------------------
[2020-10-22T20:01:24.591Z]
[2020-10-22T20:01:24.591Z] *** Maximum errors for vector of size 100: rtol=0.0001, atol=0.001
[2020-10-22T20:01:24.591Z]
[2020-10-22T20:01:24.591Z] 1: Error 1.254846 Location of error: (0, 0), NUMERICAL_x=0.82617188, BACKWARD_x=0.82753056
[2020-10-22T20:01:24.591Z] 2: Error 1.254846 Location of error: (0, 1), NUMERICAL_x=0.82617188, BACKWARD_x=0.82753056
[2020-10-22T20:01:24.591Z] 3: Error 1.254846 Location of error: (0, 2), NUMERICAL_x=0.82617188, BACKWARD_x=0.82753056
[2020-10-22T20:01:24.591Z] 4: Error 1.254846 Location of error: (0, 3), NUMERICAL_x=0.82617188, BACKWARD_x=0.82753056
[2020-10-22T20:01:24.591Z] 5: Error 1.254846 Location of error: (0, 4), NUMERICAL_x=0.82617188, BACKWARD_x=0.82753056
[2020-10-22T20:01:24.591Z] 6: Error 1.254846 Location of error: (0, 5), NUMERICAL_x=0.82617188, BACKWARD_x=0.82753056
[2020-10-22T20:01:24.591Z] 7: Error 1.254846 Location of error: (0, 6), NUMERICAL_x=0.82617188, BACKWARD_x=0.82753056
[2020-10-22T20:01:24.591Z] 8: Error 1.254846 Location of error: (0, 7), NUMERICAL_x=0.82617188, BACKWARD_x=0.82753056
[2020-10-22T20:01:24.591Z] 9: Error 1.254846 Location of error: (0, 8), NUMERICAL_x=0.82617188, BACKWARD_x=0.82753056
[2020-10-22T20:01:24.591Z] 10: Error 1.254846 Location of error: (0, 9), NUMERICAL_x=0.82617188, BACKWARD_x=0.82753056
[2020-10-22T20:01:24.591Z]
[2020-10-22T20:01:24.591Z] --------------------- >> end captured stdout << ----------------------
[2020-10-22T20:01:24.591Z] -------------------- >> begin captured logging << --------------------
[2020-10-22T20:01:24.591Z] common: WARNING: Error seen with seeded test, use MXNET_TEST_SEED=1917660267 to reproduce.
[2020-10-22T20:01:24.591Z] --------------------- >> end captured logging << ---------------------
[2020-10-22T20:01:24.591Z]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19407: [LICENSE] [v1.x] Change intgemm to a submodule instead of fetch.
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19407:
URL: https://github.com/apache/incubator-mxnet/pull/19407
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19407: [LICENSE] [v1.x] Change intgemm to a submodule instead of fetch.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19407:
URL: https://github.com/apache/incubator-mxnet/pull/19407#issuecomment-714759321
Jenkins CI successfully triggered : [unix-cpu, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19407: [LICENSE] [v1.x] Change intgemm to a submodule instead of fetch.
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19407:
URL: https://github.com/apache/incubator-mxnet/pull/19407#issuecomment-714654154
Hey @kpuatamazon , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, windows-gpu, unix-gpu, windows-cpu, clang, sanity, unix-cpu, miscellaneous, website, centos-cpu, centos-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org