You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by an...@apache.org on 2016/10/06 14:43:49 UTC

[2/4] jena git commit: Don't mix reformatting and functional changes

Don't mix reformatting and functional changes


Project: http://git-wip-us.apache.org/repos/asf/jena/repo
Commit: http://git-wip-us.apache.org/repos/asf/jena/commit/c12b574a
Tree: http://git-wip-us.apache.org/repos/asf/jena/tree/c12b574a
Diff: http://git-wip-us.apache.org/repos/asf/jena/diff/c12b574a

Branch: refs/heads/master
Commit: c12b574abc18e5e72a84afb16b162d74a82364e7
Parents: b5cb136
Author: Andy Seaborne <an...@apache.org>
Authored: Sun Oct 2 20:57:34 2016 +0100
Committer: Andy Seaborne <an...@apache.org>
Committed: Sun Oct 2 20:57:34 2016 +0100

----------------------------------------------------------------------
 CONTRIBUTING.md | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/jena/blob/c12b574a/CONTRIBUTING.md
----------------------------------------------------------------------
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 2170476..4eb447f 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -68,7 +68,7 @@ https://jena.apache.org/getting_involved/reviewing_contributions.html
 
 An alternative is to upload a patch/diff to JIRA.
 
-### Code style
+### Code
 
 Code style is about making the code clear for the next person
 who looks at the code.
@@ -94,17 +94,21 @@ The code should have no warnings, in particular, use `@Override` and types
 for generics, and don't declared checked exceptions that are not used.
 Use `@SuppressWarnings("unused")` as necessary.
 
+Please don't mix reformatting and functional changes; it makes it harder
+to review.
+
 ### Legal
 
 All contributions are understood to be made as contributions to the
-Apache Software Foundation. These are then incorporated into the project
-ocdebase and licneses under the Apache License 2.0.
+Apache Software Foundation by the person makign the pull request. These
+are then incorporated into the project codebase and licnesed under the
+Apache License 2.0.
 
 You, as an individual, must be entitled to make the contribution to the
 project. If the contrbution is part of your employment, please arrange
 this before making the contribution.
 
-For a large contribution, the Project may ask for a specific Software
+For a large contribution, the project may ask for a specific Software
 Grant from the contributor.
 
 If in doubt, or you have any questions, ask on the dev@jena.apache.org