You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "GC-20-20 (via GitHub)" <gi...@apache.org> on 2024/07/16 08:42:49 UTC
[PR] /rp2040 Rename the RP2040-specific PWM_MULTICHAN definition [nuttx]
GC-20-20 opened a new pull request, #12707:
URL: https://github.com/apache/nuttx/pull/12707
## Summary
Under arch/arm/src/rp2040/Kconfig, pwm-multichan is defined the same as the global one. Rename the RP2040-specific PWM_MULTICHAN definition to avoid confusion with the global PWM_MULTICHAN.
## Impact
Only the RP2040 prefix is added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] /rp2040 Rename the RP2040-specific PWM_MULTICHAN definition [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12707:
URL: https://github.com/apache/nuttx/pull/12707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] /rp2040 Rename the RP2040-specific PWM_MULTICHAN definition [nuttx]
Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea commented on PR #12707:
URL: https://github.com/apache/nuttx/pull/12707#issuecomment-2230803794
@acassis good remark
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] /rp2040 Rename the RP2040-specific PWM_MULTICHAN definition [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12707:
URL: https://github.com/apache/nuttx/pull/12707#issuecomment-2230775305
@xiaoxiang781216 although you @jerpelea and @pkarashchenko approved it and you merged without considering my suggestion, I think this PR (and the original Kconfig before this PR) is not right.
PWM Multichannel is defined at driver/timer/Kconfig and at arch/ we just need to use it, we don't need to include a new Kconfig.
This kind of modification help to spread confusion inside NuttX, please follow the standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] /rp2040 Rename the RP2040-specific PWM_MULTICHAN definition [nuttx]
Posted by "GC-20-20 (via GitHub)" <gi...@apache.org>.
GC-20-20 commented on PR #12707:
URL: https://github.com/apache/nuttx/pull/12707#issuecomment-2232133688
> @GC-20-20 did you look how CONFIG_PWM_NCHANNELS is implemented for other arch?你有没有看过其他 ARC 是如何实现CONFIG_PWM_NCHANNELS的？ They are not defining it, but just using it in the xxx_pwm.c他们没有定义它，而只是在 xxx_pwm.c 中使用它
>
> I suggest you do to the same.我建议你也这样做。
@acassis @xiaoxiang781216
Yes, I want to modify this kconfig for this reason too. But because the PWM Multichannel of rp2040 is placed under System Type. So I wanted to add a prefix to this basis to explain it. Thanks for the suggestion, not generating a new Kconfig is the best decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] /rp2040 Rename the RP2040-specific PWM_MULTICHAN definition [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #12707:
URL: https://github.com/apache/nuttx/pull/12707#issuecomment-2230858470
> @xiaoxiang781216 although you @jerpelea and @pkarashchenko approved it and you merged without considering my suggestion, I think this PR (and the original Kconfig before this PR) is not right.
>
> PWM Multichannel is defined at driver/timer/Kconfig and at arch/ we just need to use it, we don't need to include a new Kconfig.
>
> This kind of modification helps to spread confusion inside NuttX, please follow the standard.
Sorry, I have saw your comment. @GC-20-20 please verify @acassis ‘s suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] /rp2040 Rename the RP2040-specific PWM_MULTICHAN definition [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12707:
URL: https://github.com/apache/nuttx/pull/12707#issuecomment-2230680217
@GC-20-20 did you look how CONFIG_PWM_NCHANNELS is implemented for other arch?
They are not defining it, but just using it in the xxx_pwm.c
I suggest you do to the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org