You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/10/22 03:11:48 UTC

[GitHub] [pulsar] hangc0276 commented on a change in pull request #12457: Stop OffsetStore when stopping the connector

hangc0276 commented on a change in pull request #12457:
URL: https://github.com/apache/pulsar/pull/12457#discussion_r734205075



##########
File path: pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/PulsarOffsetBackingStore.java
##########
@@ -158,19 +158,35 @@ public void start() {
 
     @Override
     public void stop() {
+        log.info("Stopping PulsarOffsetBackingStore");
         if (null != producer) {
+            try {
+                producer.flush();

Review comment:
       Can we put the flush and close in the same try-catch block?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org