You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@bellsouth.net> on 2000/07/28 21:14:55 UTC
Re: cvs commit: apache-2.0/src/include http_config.h
rbb@locus.apache.org writes:
> rbb 00/07/28 11:53:03
>
> Modified: src/include http_config.h
> Log:
> Add the macro for AP_INIT_TAKE3 directives. I am assuming this was left
> out by mistake.
>
> Revision Changes Path
> 1.41 +4 -0 apache-2.0/src/include/http_config.h
>
> Index: http_config.h
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/include/http_config.h,v
> retrieving revision 1.40
> retrieving revision 1.41
> diff -u -r1.40 -r1.41
> --- http_config.h 2000/07/26 15:33:39 1.40
> +++ http_config.h 2000/07/28 18:53:01 1.41
> @@ -135,6 +135,8 @@
> { directive, { .take2=func }, mconfig, where, ITERATE2, help }
> # define AP_INIT_TAKE23(directive, func, mconfig, where, help) \
> { directive, { .take3=func }, mconfig, where, TAKE23, help }
> +# define AP_INIT_TAKE3(directive, func, mconfig, where, help) \
> + { directive, { .take3=func }, mconfig, where, TAKE23, help }
Why isn't that TAKE3 instead of TAKE23? +
(same question a few lines lower)
--
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...
Re: cvs commit: apache-2.0/src/include http_config.h
Posted by Ben Laurie <be...@algroup.co.uk>.
rbb@covalent.net wrote:
>
> On 28 Jul 2000, Jeff Trawick wrote:
>
> > rbb@locus.apache.org writes:
> >
> > > rbb 00/07/28 11:53:03
>
> > > # define AP_INIT_TAKE23(directive, func, mconfig, where, help) \
> > > { directive, { .take3=func }, mconfig, where, TAKE23, help }
> > > +# define AP_INIT_TAKE3(directive, func, mconfig, where, help) \
> > > + { directive, { .take3=func }, mconfig, where, TAKE23, help }
> >
> > Why isn't that TAKE3 instead of TAKE23? +
> >
> > (same question a few lines lower)
>
> What is the question? We have always had the ability to do a TAKE23 and a
> TAKE3. The original change left out the TAKE3 macros. I just needed to
You've used TAKE23 instead of TAKE3 in AP_INIT_TAKE3.
Cheers,
Ben.
--
http://www.apache-ssl.org/ben.html
Coming to ApacheCon Europe 2000? http://apachecon.com/
Re: cvs commit: apache-2.0/src/include http_config.h
Posted by rb...@covalent.net.
On 28 Jul 2000, Jeff Trawick wrote:
> rbb@covalent.net writes:
>
> > On 28 Jul 2000, Jeff Trawick wrote:
> >
> > > rbb@locus.apache.org writes:
> > >
> > > > rbb 00/07/28 11:53:03
> >
> > > > # define AP_INIT_TAKE23(directive, func, mconfig, where, help) \
> > > > { directive, { .take3=func }, mconfig, where, TAKE23, help }
> > > > +# define AP_INIT_TAKE3(directive, func, mconfig, where, help) \
> > > > + { directive, { .take3=func }, mconfig, where, TAKE23, help }
> > >
> > > Why isn't that TAKE3 instead of TAKE23? +
> > >
> > > (same question a few lines lower)
> I guess my placement of the '+' sign at the end of my question wasn't
> clear :) Let's try again.
OK. Now I see the question. I missed the + completely last time. I'll
fix this ASAP.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: cvs commit: apache-2.0/src/include http_config.h
Posted by Jeff Trawick <tr...@bellsouth.net>.
rbb@covalent.net writes:
> On 28 Jul 2000, Jeff Trawick wrote:
>
> > rbb@locus.apache.org writes:
> >
> > > rbb 00/07/28 11:53:03
>
> > > # define AP_INIT_TAKE23(directive, func, mconfig, where, help) \
> > > { directive, { .take3=func }, mconfig, where, TAKE23, help }
> > > +# define AP_INIT_TAKE3(directive, func, mconfig, where, help) \
> > > + { directive, { .take3=func }, mconfig, where, TAKE23, help }
> >
> > Why isn't that TAKE3 instead of TAKE23? +
> >
> > (same question a few lines lower)
>
> What is the question? We have always had the ability to do a TAKE23 and a
> TAKE3. The original change left out the TAKE3 macros. I just needed to
> fix that.
I guess my placement of the '+' sign at the end of my question wasn't
clear :) Let's try again.
In your new AP_INIT_TAKE3() macros, it seems to me that you are
initializing the command_rec to state that the command can take either
2 or 3 parameters. Look at the initializer for the next to last field
in command_rec. You have TAKE23 instead of TAKE3.
In other words, why isn't your new macro instead
# define AP_INIT_TAKE3(directive, func, mconfig, where, help) \
{ directive, { .take3=func }, mconfig, where, TAKE3, help }
I think your version means that the config code will let the user get
away with specifying 2 arguments to a command that requires 3
arguments. However, TAKE3 means that the command must have 3
parameters and the module coder shouldn't have to check on whether 2
or three arguments were specified. O.k.?
--
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...
Re: cvs commit: apache-2.0/src/include http_config.h
Posted by rb...@covalent.net.
On 28 Jul 2000, Jeff Trawick wrote:
> rbb@locus.apache.org writes:
>
> > rbb 00/07/28 11:53:03
> > # define AP_INIT_TAKE23(directive, func, mconfig, where, help) \
> > { directive, { .take3=func }, mconfig, where, TAKE23, help }
> > +# define AP_INIT_TAKE3(directive, func, mconfig, where, help) \
> > + { directive, { .take3=func }, mconfig, where, TAKE23, help }
>
> Why isn't that TAKE3 instead of TAKE23? +
>
> (same question a few lines lower)
What is the question? We have always had the ability to do a TAKE23 and a
TAKE3. The original change left out the TAKE3 macros. I just needed to
fix that.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------