You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/04/09 09:40:55 UTC

[GitHub] [arrow-datafusion] jackwener opened a new issue, #5928: Type coercion should select cheapest cast.

jackwener opened a new issue, #5928:
URL: https://github.com/apache/arrow-datafusion/issues/5928

   ### Describe the bug
   
   a Expr like `col(a) > utf('8')`. 
   We shouldn't cast `col(a)`.
   
   ### To Reproduce
   
   ```rs
       #[test]
       fn between_infer_cheap_type() -> Result<()> {
           let expr = Expr::Between(Between::new(
               Box::new(col("a")),
               false,
               // (cast('2002-05-08' as date) + interval '1 months')
               Box::new(Expr::BinaryExpr(BinaryExpr {
                   left: Box::new(Expr::Cast(Cast {
                       expr: Box::new(Expr::Literal(Utf8(Some("2002-05-08".to_string())))),
                       data_type: DataType::Date32,
                   })),
                   op: Operator::Plus,
                   right: Box::new(Expr::Literal(ScalarValue::IntervalYearMonth(Some(1)))),
               })),
               Box::new(Expr::Literal(Utf8(Some("2002-12-08".to_string())))),
           ));
           let empty = empty_with_type(DataType::Utf8);
           let plan = LogicalPlan::Filter(Filter::try_new(expr, empty)?);
           // TODO
           let expected =
               "Filter: CAST(a AS Date32) BETWEEN CAST(Utf8(\"2002-05-08\") AS Date32) + IntervalYearMonth(\"1\") AND CAST(Utf8(\"2002-12-08\") AS Date32)\
               \n  EmptyRelation";
           assert_analyzed_plan_eq(Arc::new(TypeCoercion::new()), &plan, expected)
       }
   ```
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org