[Bug 51953] Proposal: netmask filtering valve and filter [PATCH]

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=51953

--- Comment #24 from Mark Thomas <ma...@apache.org> ---
It has been rather too long since this was last looked at. Apologies for that.
I'm looking at this now.

The good news is that the patch applies cleanly to trunk (9.0.x). There are
some compilation issues to take care of (e.g. Comet has been removed) but
nothing major.

I'm planning on starting with the NetMask and associated unit tests. I've
tidied up some Checkstyle / formatting issues and I'm now looking at
refactoring the unit test coverage to a) use a parameterized test and b) expand
the test cases. I also want to look at the Exception messages as the current
message look slightly odd and I want to switch them over to the StringManager
for i18n support.

I'll look at the Valve and Filter once the netmask work is complete.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org