You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "francisoliverlee (via GitHub)" <gi...@apache.org> on 2023/02/22 03:58:03 UTC

[GitHub] [rocketmq-client-go] francisoliverlee commented on issue #973: VerifyIP blocked DNS style

francisoliverlee commented on issue #973:
URL: https://github.com/apache/rocketmq-client-go/issues/973#issuecomment-1439404905

   从现在的逻辑看，是需要检查namesrv地址的有效性，
   1. ipv4
   2. ipv6
   3. http://或者https://开头。
   
   这个检查没有覆盖namesrv1.com, namesrv1.com;namesrv2.com这种域名场景， 非常欢迎你提交PR修复它。
   
   VerifyIP()代码：
   https://github.com/apache/rocketmq-client-go/blob/26142da1b88ef22ac018138c724f5d4f48059da3/primitive/base.go#L33-L86
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org