You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/13 14:50:52 UTC

[GitHub] [arrow] paleolimbot commented on a diff in pull request #15278: GH-14474: Opportunistically delete R references to shared pointers where possible

paleolimbot commented on code in PR #15278:
URL: https://github.com/apache/arrow/pull/15278#discussion_r1069549725


##########
r/R/record-batch-reader.R:
##########
@@ -255,6 +259,8 @@ as_record_batch_reader.arrow_dplyr_query <- function(x, ...) {
   # See query-engine.R for ExecPlan/Nodes
   plan <- ExecPlan$create()
   final_node <- plan$Build(x)
+  on.exit(plan$.unsafe_delete())

Review Comment:
   Good catch! I added an `on.exit()` for both of these.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org