[GitHub] [solr] janhoy commented on a change in pull request #372: SOLR-11623 Every request handler in Solr implement PermissionNameProvider

[GitBox <gi...@apache.org>]

janhoy commented on a change in pull request #372:
URL: https://github.com/apache/solr/pull/372#discussion_r737795303



##########
File path: solr/core/src/java/org/apache/solr/handler/DumpRequestHandler.java
##########
@@ -126,4 +127,9 @@ public void init(NamedList<?> args) {
       if (nl!=null) subpaths = nl.getAll("subpath");
     }
   }
+
+  @Override
+  public Name getPermissionName(AuthorizationContext request) {
+    return Name.CONFIG_READ_PERM;

Review comment:
       Reminds me of https://issues.apache.org/jira/browse/SOLR-14853. What if we made it a global option, then we could change the permission needed based on whether remote streaming is enabled or not? But I'm open to the idea of changing it to `ALL`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org