You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sebastien Goasguen <ru...@gmail.com> on 2013/06/20 14:35:10 UTC

easy bug to fix for new comer

Hi,

Here is an easy bug to fix for a newcomer to cloudstack:

https://issues.apache.org/jira/browse/CLOUDSTACK-3096

install pep8 on your machine
git clone cloudstack repo
go to the marvin directory

run pep8 like I show in the bug.

edit the python scripts to fix the errors

once pep8 is clean, git commit everything, create a patch and send to review board.

Any takers ?

-Sebastien

Re: easy bug to fix for new comer

Posted by Sebastien Goasguen <ru...@gmail.com>.
Daan, also assign the bug to yourself in JIRA…

If you cannot do it, we need to give you "karma"

On Jun 20, 2013, at 1:04 PM, Sebastien Goasguen <ru...@gmail.com> wrote:

> Daan,
> 
> Your patches applied cleanly and have been committed to master.
> Please mark the review as submitted
> 
> In your next patches try to use the bug id in at the start of the comment, that way the commit will automatically show up in JIRA and review board…magic.
> 
> do something like that:
> 
> git commit -m "CLOUDSTACK-3096: blah blah blah…."
> 
> You can also send everything as a single commit…just edit the files, stage them, git add….and do a single commit.
> 
> thanks a lot…I told you this was an easy one :)
> 
> -sebastien
> 
> On Jun 20, 2013, at 11:44 AM, Sebastien Goasguen <ru...@gmail.com> wrote:
> 
>> thanks, I will check your patches now
>> 
>> 
>> On Jun 20, 2013, at 10:54 AM, Daan Hoogland <DH...@schubergphilis.com> wrote:
>> 
>>> Halting now, will take on the bigger ones tonight/-morow
>>> 
>>> -----Original Message-----
>>> From: Daan Hoogland [mailto:DHoogland@schubergphilis.com] 
>>> Sent: donderdag 20 juni 2013 16:12
>>> To: 'dev@cloudstack.apache.org'
>>> Subject: RE: easy bug to fix for new comer
>>> 
>>> I noticed some are very small. Doing those first and I am still doing them one file at a time!
>>> 
>>> -----Original Message-----
>>> From: Prasanna Santhanam [mailto:tsp@apache.org] 
>>> Sent: donderdag 20 juni 2013 16:02
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: easy bug to fix for new comer
>>> 
>>> cloudstackConnection was pep8 compliant but seems to have flouted it again. I'll look at setting up a jenkins job for style check when the full pep8 compliance is done.
>>> 
>>> On Thu, Jun 20, 2013 at 01:42:36PM +0000, Daan Hoogland wrote:
>>>> Sure,
>>>> 
>>>> One file at a time!
>>>> 
>>>> -----Original Message-----
>>>> From: Sebastien Goasguen [mailto:runseb@gmail.com]
>>>> Sent: donderdag 20 juni 2013 14:35
>>>> To: dev@cloudstack.apache.org
>>>> Subject: easy bug to fix for new comer
>>>> 
>>>> Hi,
>>>> 
>>>> Here is an easy bug to fix for a newcomer to cloudstack:
>>>> 
>>>> https://issues.apache.org/jira/browse/CLOUDSTACK-3096
>>>> 
>>>> install pep8 on your machine
>>>> git clone cloudstack repo
>>>> go to the marvin directory
>>>> 
>>>> run pep8 like I show in the bug.
>>>> 
>>>> edit the python scripts to fix the errors
>>>> 
>>>> once pep8 is clean, git commit everything, create a patch and send to review board.
>>>> 
>>>> Any takers ?
>>>> 
>>>> -Sebastien
>>> 
>>> --
>>> Prasanna.,
>>> 
>>> ------------------------
>>> Powered by BigRock.com
>>> 
>> 
> 


Re: easy bug to fix for new comer

Posted by Chip Childers <ch...@sungard.com>.
On Fri, Jun 21, 2013 at 03:28:48PM +0200, Daan Hoogland wrote:
> five files to go. I may finish it on the plane or else next week.

Very productive week for you!  Thanks Daan.

Re: easy bug to fix for new comer

Posted by Daan Hoogland <da...@gmail.com>.
five files to go. I may finish it on the plane or else next week.


On Fri, Jun 21, 2013 at 11:12 AM, Daan Hoogland <da...@gmail.com>wrote:

> I submitted a biggy. please review this and consider whether pep8 is
> beating the purpose of formatting. Espacially line length of 80 seems not
> what you want. You'll want your terminals show more character then that in
> this century.
>
>
> On Fri, Jun 21, 2013 at 10:07 AM, Prasanna Santhanam <ts...@apache.org>wrote:
>
>> Yup - please skip that too.
>>
>> On Fri, Jun 21, 2013 at 09:56:47AM +0200, Daan Hoogland wrote:
>> > how about sandbox? It doesn't sound like really long term strategic code
>> > either.
>> >
>> >
>> > On Fri, Jun 21, 2013 at 8:02 AM, Prasanna Santhanam <ts...@apache.org>
>> wrote:
>> >
>> > > One other thing: You can skip pep8-ing the integration module since
>> > > that will be deprecated in the future. There's a lot of classes in
>> > > there so it'll save you time.
>> > >
>> > > On Thu, Jun 20, 2013 at 01:04:55PM -0400, Sebastien Goasguen wrote:
>> > > > Daan,
>> > > >
>> > > > Your patches applied cleanly and have been committed to master.
>> > > > Please mark the review as submitted
>> > > >
>> > > > In your next patches try to use the bug id in at the start of the
>> > > comment, that way the commit will automatically show up in JIRA and
>> review
>> > > board?magic.
>> > > >
>> > > > do something like that:
>> > > >
>> > > > git commit -m "CLOUDSTACK-3096: blah blah blah?."
>> > > >
>> > > > You can also send everything as a single commit?just edit the files,
>> > > stage them, git add?.and do a single commit.
>> > > >
>> > > > thanks a lot?I told you this was an easy one :)
>> > > >
>> > > > -sebastien
>> > > >
>> > > > On Jun 20, 2013, at 11:44 AM, Sebastien Goasguen <ru...@gmail.com>
>> > > wrote:
>> > > >
>> > > --
>> > > Prasanna.,
>> > >
>> > > ------------------------
>> > > Powered by BigRock.com
>> > >
>> > >
>>
>> --
>> Prasanna.,
>>
>> ------------------------
>> Powered by BigRock.com
>>
>>
>

Re: easy bug to fix for new comer

Posted by Daan Hoogland <da...@gmail.com>.
I submitted a biggy. please review this and consider whether pep8 is
beating the purpose of formatting. Espacially line length of 80 seems not
what you want. You'll want your terminals show more character then that in
this century.


On Fri, Jun 21, 2013 at 10:07 AM, Prasanna Santhanam <ts...@apache.org> wrote:

> Yup - please skip that too.
>
> On Fri, Jun 21, 2013 at 09:56:47AM +0200, Daan Hoogland wrote:
> > how about sandbox? It doesn't sound like really long term strategic code
> > either.
> >
> >
> > On Fri, Jun 21, 2013 at 8:02 AM, Prasanna Santhanam <ts...@apache.org>
> wrote:
> >
> > > One other thing: You can skip pep8-ing the integration module since
> > > that will be deprecated in the future. There's a lot of classes in
> > > there so it'll save you time.
> > >
> > > On Thu, Jun 20, 2013 at 01:04:55PM -0400, Sebastien Goasguen wrote:
> > > > Daan,
> > > >
> > > > Your patches applied cleanly and have been committed to master.
> > > > Please mark the review as submitted
> > > >
> > > > In your next patches try to use the bug id in at the start of the
> > > comment, that way the commit will automatically show up in JIRA and
> review
> > > board?magic.
> > > >
> > > > do something like that:
> > > >
> > > > git commit -m "CLOUDSTACK-3096: blah blah blah?."
> > > >
> > > > You can also send everything as a single commit?just edit the files,
> > > stage them, git add?.and do a single commit.
> > > >
> > > > thanks a lot?I told you this was an easy one :)
> > > >
> > > > -sebastien
> > > >
> > > > On Jun 20, 2013, at 11:44 AM, Sebastien Goasguen <ru...@gmail.com>
> > > wrote:
> > > >
> > > --
> > > Prasanna.,
> > >
> > > ------------------------
> > > Powered by BigRock.com
> > >
> > >
>
> --
> Prasanna.,
>
> ------------------------
> Powered by BigRock.com
>
>

Re: easy bug to fix for new comer

Posted by Prasanna Santhanam <ts...@apache.org>.
Yup - please skip that too.

On Fri, Jun 21, 2013 at 09:56:47AM +0200, Daan Hoogland wrote:
> how about sandbox? It doesn't sound like really long term strategic code
> either.
> 
> 
> On Fri, Jun 21, 2013 at 8:02 AM, Prasanna Santhanam <ts...@apache.org> wrote:
> 
> > One other thing: You can skip pep8-ing the integration module since
> > that will be deprecated in the future. There's a lot of classes in
> > there so it'll save you time.
> >
> > On Thu, Jun 20, 2013 at 01:04:55PM -0400, Sebastien Goasguen wrote:
> > > Daan,
> > >
> > > Your patches applied cleanly and have been committed to master.
> > > Please mark the review as submitted
> > >
> > > In your next patches try to use the bug id in at the start of the
> > comment, that way the commit will automatically show up in JIRA and review
> > board?magic.
> > >
> > > do something like that:
> > >
> > > git commit -m "CLOUDSTACK-3096: blah blah blah?."
> > >
> > > You can also send everything as a single commit?just edit the files,
> > stage them, git add?.and do a single commit.
> > >
> > > thanks a lot?I told you this was an easy one :)
> > >
> > > -sebastien
> > >
> > > On Jun 20, 2013, at 11:44 AM, Sebastien Goasguen <ru...@gmail.com>
> > wrote:
> > >
> > --
> > Prasanna.,
> >
> > ------------------------
> > Powered by BigRock.com
> >
> >

-- 
Prasanna.,

------------------------
Powered by BigRock.com


Re: easy bug to fix for new comer

Posted by Daan Hoogland <da...@gmail.com>.
how about sandbox? It doesn't sound like really long term strategic code
either.


On Fri, Jun 21, 2013 at 8:02 AM, Prasanna Santhanam <ts...@apache.org> wrote:

> One other thing: You can skip pep8-ing the integration module since
> that will be deprecated in the future. There's a lot of classes in
> there so it'll save you time.
>
> On Thu, Jun 20, 2013 at 01:04:55PM -0400, Sebastien Goasguen wrote:
> > Daan,
> >
> > Your patches applied cleanly and have been committed to master.
> > Please mark the review as submitted
> >
> > In your next patches try to use the bug id in at the start of the
> comment, that way the commit will automatically show up in JIRA and review
> board?magic.
> >
> > do something like that:
> >
> > git commit -m "CLOUDSTACK-3096: blah blah blah?."
> >
> > You can also send everything as a single commit?just edit the files,
> stage them, git add?.and do a single commit.
> >
> > thanks a lot?I told you this was an easy one :)
> >
> > -sebastien
> >
> > On Jun 20, 2013, at 11:44 AM, Sebastien Goasguen <ru...@gmail.com>
> wrote:
> >
> --
> Prasanna.,
>
> ------------------------
> Powered by BigRock.com
>
>

Re: easy bug to fix for new comer

Posted by Prasanna Santhanam <ts...@apache.org>.
One other thing: You can skip pep8-ing the integration module since
that will be deprecated in the future. There's a lot of classes in
there so it'll save you time.

On Thu, Jun 20, 2013 at 01:04:55PM -0400, Sebastien Goasguen wrote:
> Daan,
> 
> Your patches applied cleanly and have been committed to master.
> Please mark the review as submitted
> 
> In your next patches try to use the bug id in at the start of the comment, that way the commit will automatically show up in JIRA and review board?magic.
> 
> do something like that:
> 
> git commit -m "CLOUDSTACK-3096: blah blah blah?."
> 
> You can also send everything as a single commit?just edit the files, stage them, git add?.and do a single commit.
> 
> thanks a lot?I told you this was an easy one :)
> 
> -sebastien
> 
> On Jun 20, 2013, at 11:44 AM, Sebastien Goasguen <ru...@gmail.com> wrote:
> 
-- 
Prasanna.,

------------------------
Powered by BigRock.com


Re: easy bug to fix for new comer

Posted by Sebastien Goasguen <ru...@gmail.com>.
Daan,

Your patches applied cleanly and have been committed to master.
Please mark the review as submitted

In your next patches try to use the bug id in at the start of the comment, that way the commit will automatically show up in JIRA and review board…magic.

do something like that:

git commit -m "CLOUDSTACK-3096: blah blah blah…."

You can also send everything as a single commit…just edit the files, stage them, git add….and do a single commit.

thanks a lot…I told you this was an easy one :)

-sebastien

On Jun 20, 2013, at 11:44 AM, Sebastien Goasguen <ru...@gmail.com> wrote:

> thanks, I will check your patches now
> 
> 
> On Jun 20, 2013, at 10:54 AM, Daan Hoogland <DH...@schubergphilis.com> wrote:
> 
>> Halting now, will take on the bigger ones tonight/-morow
>> 
>> -----Original Message-----
>> From: Daan Hoogland [mailto:DHoogland@schubergphilis.com] 
>> Sent: donderdag 20 juni 2013 16:12
>> To: 'dev@cloudstack.apache.org'
>> Subject: RE: easy bug to fix for new comer
>> 
>> I noticed some are very small. Doing those first and I am still doing them one file at a time!
>> 
>> -----Original Message-----
>> From: Prasanna Santhanam [mailto:tsp@apache.org] 
>> Sent: donderdag 20 juni 2013 16:02
>> To: dev@cloudstack.apache.org
>> Subject: Re: easy bug to fix for new comer
>> 
>> cloudstackConnection was pep8 compliant but seems to have flouted it again. I'll look at setting up a jenkins job for style check when the full pep8 compliance is done.
>> 
>> On Thu, Jun 20, 2013 at 01:42:36PM +0000, Daan Hoogland wrote:
>>> Sure,
>>> 
>>> One file at a time!
>>> 
>>> -----Original Message-----
>>> From: Sebastien Goasguen [mailto:runseb@gmail.com]
>>> Sent: donderdag 20 juni 2013 14:35
>>> To: dev@cloudstack.apache.org
>>> Subject: easy bug to fix for new comer
>>> 
>>> Hi,
>>> 
>>> Here is an easy bug to fix for a newcomer to cloudstack:
>>> 
>>> https://issues.apache.org/jira/browse/CLOUDSTACK-3096
>>> 
>>> install pep8 on your machine
>>> git clone cloudstack repo
>>> go to the marvin directory
>>> 
>>> run pep8 like I show in the bug.
>>> 
>>> edit the python scripts to fix the errors
>>> 
>>> once pep8 is clean, git commit everything, create a patch and send to review board.
>>> 
>>> Any takers ?
>>> 
>>> -Sebastien
>> 
>> --
>> Prasanna.,
>> 
>> ------------------------
>> Powered by BigRock.com
>> 
> 


Re: easy bug to fix for new comer

Posted by Sebastien Goasguen <ru...@gmail.com>.
thanks, I will check your patches now


On Jun 20, 2013, at 10:54 AM, Daan Hoogland <DH...@schubergphilis.com> wrote:

> Halting now, will take on the bigger ones tonight/-morow
> 
> -----Original Message-----
> From: Daan Hoogland [mailto:DHoogland@schubergphilis.com] 
> Sent: donderdag 20 juni 2013 16:12
> To: 'dev@cloudstack.apache.org'
> Subject: RE: easy bug to fix for new comer
> 
> I noticed some are very small. Doing those first and I am still doing them one file at a time!
> 
> -----Original Message-----
> From: Prasanna Santhanam [mailto:tsp@apache.org] 
> Sent: donderdag 20 juni 2013 16:02
> To: dev@cloudstack.apache.org
> Subject: Re: easy bug to fix for new comer
> 
> cloudstackConnection was pep8 compliant but seems to have flouted it again. I'll look at setting up a jenkins job for style check when the full pep8 compliance is done.
> 
> On Thu, Jun 20, 2013 at 01:42:36PM +0000, Daan Hoogland wrote:
>> Sure,
>> 
>> One file at a time!
>> 
>> -----Original Message-----
>> From: Sebastien Goasguen [mailto:runseb@gmail.com]
>> Sent: donderdag 20 juni 2013 14:35
>> To: dev@cloudstack.apache.org
>> Subject: easy bug to fix for new comer
>> 
>> Hi,
>> 
>> Here is an easy bug to fix for a newcomer to cloudstack:
>> 
>> https://issues.apache.org/jira/browse/CLOUDSTACK-3096
>> 
>> install pep8 on your machine
>> git clone cloudstack repo
>> go to the marvin directory
>> 
>> run pep8 like I show in the bug.
>> 
>> edit the python scripts to fix the errors
>> 
>> once pep8 is clean, git commit everything, create a patch and send to review board.
>> 
>> Any takers ?
>> 
>> -Sebastien
> 
> --
> Prasanna.,
> 
> ------------------------
> Powered by BigRock.com
> 


RE: easy bug to fix for new comer

Posted by Daan Hoogland <DH...@schubergphilis.com>.
Halting now, will take on the bigger ones tonight/-morow

-----Original Message-----
From: Daan Hoogland [mailto:DHoogland@schubergphilis.com] 
Sent: donderdag 20 juni 2013 16:12
To: 'dev@cloudstack.apache.org'
Subject: RE: easy bug to fix for new comer

I noticed some are very small. Doing those first and I am still doing them one file at a time!

-----Original Message-----
From: Prasanna Santhanam [mailto:tsp@apache.org] 
Sent: donderdag 20 juni 2013 16:02
To: dev@cloudstack.apache.org
Subject: Re: easy bug to fix for new comer

cloudstackConnection was pep8 compliant but seems to have flouted it again. I'll look at setting up a jenkins job for style check when the full pep8 compliance is done.

On Thu, Jun 20, 2013 at 01:42:36PM +0000, Daan Hoogland wrote:
> Sure,
> 
> One file at a time!
> 
> -----Original Message-----
> From: Sebastien Goasguen [mailto:runseb@gmail.com]
> Sent: donderdag 20 juni 2013 14:35
> To: dev@cloudstack.apache.org
> Subject: easy bug to fix for new comer
> 
> Hi,
> 
> Here is an easy bug to fix for a newcomer to cloudstack:
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3096
> 
> install pep8 on your machine
> git clone cloudstack repo
> go to the marvin directory
> 
> run pep8 like I show in the bug.
> 
> edit the python scripts to fix the errors
> 
> once pep8 is clean, git commit everything, create a patch and send to review board.
> 
> Any takers ?
> 
> -Sebastien

--
Prasanna.,

------------------------
Powered by BigRock.com


RE: easy bug to fix for new comer

Posted by Daan Hoogland <DH...@schubergphilis.com>.
I noticed some are very small. Doing those first and I am still doing them one file at a time!

-----Original Message-----
From: Prasanna Santhanam [mailto:tsp@apache.org] 
Sent: donderdag 20 juni 2013 16:02
To: dev@cloudstack.apache.org
Subject: Re: easy bug to fix for new comer

cloudstackConnection was pep8 compliant but seems to have flouted it again. I'll look at setting up a jenkins job for style check when the full pep8 compliance is done.

On Thu, Jun 20, 2013 at 01:42:36PM +0000, Daan Hoogland wrote:
> Sure,
> 
> One file at a time!
> 
> -----Original Message-----
> From: Sebastien Goasguen [mailto:runseb@gmail.com]
> Sent: donderdag 20 juni 2013 14:35
> To: dev@cloudstack.apache.org
> Subject: easy bug to fix for new comer
> 
> Hi,
> 
> Here is an easy bug to fix for a newcomer to cloudstack:
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3096
> 
> install pep8 on your machine
> git clone cloudstack repo
> go to the marvin directory
> 
> run pep8 like I show in the bug.
> 
> edit the python scripts to fix the errors
> 
> once pep8 is clean, git commit everything, create a patch and send to review board.
> 
> Any takers ?
> 
> -Sebastien

--
Prasanna.,

------------------------
Powered by BigRock.com


Re: easy bug to fix for new comer

Posted by Prasanna Santhanam <ts...@apache.org>.
cloudstackConnection was pep8 compliant but seems to have flouted it
again. I'll look at setting up a jenkins job for style check when the
full pep8 compliance is done.

On Thu, Jun 20, 2013 at 01:42:36PM +0000, Daan Hoogland wrote:
> Sure,
> 
> One file at a time!
> 
> -----Original Message-----
> From: Sebastien Goasguen [mailto:runseb@gmail.com] 
> Sent: donderdag 20 juni 2013 14:35
> To: dev@cloudstack.apache.org
> Subject: easy bug to fix for new comer
> 
> Hi,
> 
> Here is an easy bug to fix for a newcomer to cloudstack:
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3096
> 
> install pep8 on your machine
> git clone cloudstack repo
> go to the marvin directory
> 
> run pep8 like I show in the bug.
> 
> edit the python scripts to fix the errors
> 
> once pep8 is clean, git commit everything, create a patch and send to review board.
> 
> Any takers ?
> 
> -Sebastien

-- 
Prasanna.,

------------------------
Powered by BigRock.com


Re: easy bug to fix for new comer

Posted by Prasanna Santhanam <ts...@apache.org>.
On Thu, Jun 20, 2013 at 02:01:54PM +0000, Daan Hoogland wrote: > Btw Sebastien,
> > Newcomer as I am; how do I test the test-code tests?

The first step would be to see if you are able to build marvin 

$ mvn -Pdeveloper -pl :cloud-marvin clean install

You can run tests suitable for basic zone within devcloud if you have it setup.
See the section on "devcloud tests" in the marvin wiki. [0]

Then you can try and run the checkin tests [1] (which are broken at the
moment as a result of a merge) but I hope to fix that today.

Automated tests will be run on the test infra @
jenkins.buildacloud.org [2] so any issues in the formatting will show up
there as well.

[0] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python
[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python#Marvin-TestingwithPython-
[2] http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-smoke-matrix/


Thanks for the patches!

> 
> -----Original Message-----
> From: Daan Hoogland [mailto:DHoogland@schubergphilis.com] 
> Sent: donderdag 20 juni 2013 15:43
> To: 'dev@cloudstack.apache.org'
> Subject: RE: easy bug to fix for new comer
> 
> Sure,
> 
> One file at a time!
> 
> -----Original Message-----
> From: Sebastien Goasguen [mailto:runseb@gmail.com] 
> Sent: donderdag 20 juni 2013 14:35
> To: dev@cloudstack.apache.org
> Subject: easy bug to fix for new comer
> 
> Hi,
> 
> Here is an easy bug to fix for a newcomer to cloudstack:
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3096
> 
> install pep8 on your machine
> git clone cloudstack repo
> go to the marvin directory
> 
> run pep8 like I show in the bug.
> 
> edit the python scripts to fix the errors
> 
> once pep8 is clean, git commit everything, create a patch and send to review board.
> 
> Any takers ?
> 
> -Sebastien

-- 
Prasanna.,

------------------------
Powered by BigRock.com


RE: easy bug to fix for new comer

Posted by Daan Hoogland <DH...@schubergphilis.com>.
Btw Sebastien,

Newcomer as I am; how do I test the test-code tests?

-----Original Message-----
From: Daan Hoogland [mailto:DHoogland@schubergphilis.com] 
Sent: donderdag 20 juni 2013 15:43
To: 'dev@cloudstack.apache.org'
Subject: RE: easy bug to fix for new comer

Sure,

One file at a time!

-----Original Message-----
From: Sebastien Goasguen [mailto:runseb@gmail.com] 
Sent: donderdag 20 juni 2013 14:35
To: dev@cloudstack.apache.org
Subject: easy bug to fix for new comer

Hi,

Here is an easy bug to fix for a newcomer to cloudstack:

https://issues.apache.org/jira/browse/CLOUDSTACK-3096

install pep8 on your machine
git clone cloudstack repo
go to the marvin directory

run pep8 like I show in the bug.

edit the python scripts to fix the errors

once pep8 is clean, git commit everything, create a patch and send to review board.

Any takers ?

-Sebastien

RE: easy bug to fix for new comer

Posted by Daan Hoogland <DH...@schubergphilis.com>.
Sure,

One file at a time!

-----Original Message-----
From: Sebastien Goasguen [mailto:runseb@gmail.com] 
Sent: donderdag 20 juni 2013 14:35
To: dev@cloudstack.apache.org
Subject: easy bug to fix for new comer

Hi,

Here is an easy bug to fix for a newcomer to cloudstack:

https://issues.apache.org/jira/browse/CLOUDSTACK-3096

install pep8 on your machine
git clone cloudstack repo
go to the marvin directory

run pep8 like I show in the bug.

edit the python scripts to fix the errors

once pep8 is clean, git commit everything, create a patch and send to review board.

Any takers ?

-Sebastien