You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/04 00:32:32 UTC

[GitHub] [superset] mihir174 commented on pull request #12918: feat(style): hide dashboard header by url parameter

mihir174 commented on pull request #12918:
URL: https://github.com/apache/superset/pull/12918#issuecomment-772932592


   Agreed that this is a bit hacky but it's a good first step. We need to think about security/view permission configurations on embed links. 
   I like the way Google, for example, deals with link sharing:
   <img width="635" alt="Screen Shot 2021-02-03 at 4 31 16 PM" src="https://user-images.githubusercontent.com/64227069/106827203-431dd980-663d-11eb-90ad-b197ca6cb22b.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org