You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/04/02 20:48:08 UTC
Review Request 19939: Use a single VM for the dev cluster,
manage processes with upstart.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19939/
-----------------------------------------------------------
Review request for Aurora, Jake Farrell, Kevin Sweeney, and Maxim Khutornenko.
Repository: aurora
Description
-------
In the interest of speeding up development time in vagrant and improving accessibility to the vagrant development workflow, i've collapsed all VMs into one. This allows me to vagrant destroy/up in < 30 mins on my macbook air with a 1.6 GHz core 2 duo and 4 GB RAM. Prior to this change i could not run the vagrant environment, despite efforts to reduce the requirements of each machine.
NOTE: Reviewboard has been consistently choking on applying the true diff. examples/vagrant/provision-zookeeper.sh reflects as unchanged in this diff, but i will be removing it before pushing the commit.
Diffs
-----
Vagrantfile 52e2fff1a8011bb185e3a986fd30005d96257d05
docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec
docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887
docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53
examples/vagrant/provision-aurora-scheduler.sh 87c369e864409b616980cc451109149d57635a74
examples/vagrant/provision-dev-cluster.sh PRE-CREATION
examples/vagrant/provision-dev-environment.sh 230691100ad68244290e6605c988606baeaa6890
examples/vagrant/provision-mesos-master.sh 075d23d2dfa71521c3d739fe0eea5238de8c1a76
examples/vagrant/provision-mesos-slave.sh f42b5c30d91e3d1e95f033001c31af37d6637948
examples/vagrant/upstart/aurora-scheduler.conf PRE-CREATION
examples/vagrant/upstart/aurora-thermos-observer.conf PRE-CREATION
examples/vagrant/upstart/mesos-master.conf PRE-CREATION
examples/vagrant/upstart/mesos-slave.conf PRE-CREATION
examples/vagrant/upstart/zookeeper.conf PRE-CREATION
Diff: https://reviews.apache.org/r/19939/diff/
Testing
-------
Followed (updated) docs/tutorial.md
Thanks,
Bill Farner
Re: Review Request 19939: Use a single VM for the dev cluster,
manage processes with upstart.
Posted by Bill Farner <wf...@apache.org>.
> On April 2, 2014, 7:17 p.m., Kevin Sweeney wrote:
> > examples/vagrant/provision-dev-cluster.sh, line 80
> > <https://reviews.apache.org/r/19939/diff/1/?file=546058#file546058line80>
> >
> > Missing an install_zookeeper? Bring back the WebUI?
zookeeper is installed with apt, up top. WebUI change never went in: https://reviews.apache.org/r/17042
> On April 2, 2014, 7:17 p.m., Kevin Sweeney wrote:
> > examples/vagrant/upstart/aurora-scheduler.conf, line 28
> > <https://reviews.apache.org/r/19939/diff/1/?file=546062#file546062line28>
> >
> > Out of curiosity where do logs go now?
Great question! They land in /var/log/upstart/<name>.log, matching /etc/init/<name>.conf. Downside is that they're root-owned, so i may pipe output to logger in a follow-up.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19939/#review39333
-----------------------------------------------------------
On April 2, 2014, 6:48 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19939/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 6:48 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> In the interest of speeding up development time in vagrant and improving accessibility to the vagrant development workflow, i've collapsed all VMs into one. This allows me to vagrant destroy/up in < 30 mins on my macbook air with a 1.6 GHz core 2 duo and 4 GB RAM. Prior to this change i could not run the vagrant environment, despite efforts to reduce the requirements of each machine.
>
> NOTE: Reviewboard has been consistently choking on applying the true diff. examples/vagrant/provision-zookeeper.sh reflects as unchanged in this diff, but i will be removing it before pushing the commit.
>
>
> Diffs
> -----
>
> Vagrantfile 52e2fff1a8011bb185e3a986fd30005d96257d05
> docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec
> docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887
> docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53
> examples/vagrant/provision-aurora-scheduler.sh 87c369e864409b616980cc451109149d57635a74
> examples/vagrant/provision-dev-cluster.sh PRE-CREATION
> examples/vagrant/provision-dev-environment.sh 230691100ad68244290e6605c988606baeaa6890
> examples/vagrant/provision-mesos-master.sh 075d23d2dfa71521c3d739fe0eea5238de8c1a76
> examples/vagrant/provision-mesos-slave.sh f42b5c30d91e3d1e95f033001c31af37d6637948
> examples/vagrant/upstart/aurora-scheduler.conf PRE-CREATION
> examples/vagrant/upstart/aurora-thermos-observer.conf PRE-CREATION
> examples/vagrant/upstart/mesos-master.conf PRE-CREATION
> examples/vagrant/upstart/mesos-slave.conf PRE-CREATION
> examples/vagrant/upstart/zookeeper.conf PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19939/diff/
>
>
> Testing
> -------
>
> Followed (updated) docs/tutorial.md
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 19939: Use a single VM for the dev cluster,
manage processes with upstart.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19939/#review39333
-----------------------------------------------------------
Ship it!
Much cleaner!
examples/vagrant/provision-dev-cluster.sh
<https://reviews.apache.org/r/19939/#comment71683>
Missing an install_zookeeper? Bring back the WebUI?
examples/vagrant/upstart/aurora-scheduler.conf
<https://reviews.apache.org/r/19939/#comment71684>
Out of curiosity where do logs go now?
- Kevin Sweeney
On April 2, 2014, 11:48 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19939/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 11:48 a.m.)
>
>
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> In the interest of speeding up development time in vagrant and improving accessibility to the vagrant development workflow, i've collapsed all VMs into one. This allows me to vagrant destroy/up in < 30 mins on my macbook air with a 1.6 GHz core 2 duo and 4 GB RAM. Prior to this change i could not run the vagrant environment, despite efforts to reduce the requirements of each machine.
>
> NOTE: Reviewboard has been consistently choking on applying the true diff. examples/vagrant/provision-zookeeper.sh reflects as unchanged in this diff, but i will be removing it before pushing the commit.
>
>
> Diffs
> -----
>
> Vagrantfile 52e2fff1a8011bb185e3a986fd30005d96257d05
> docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec
> docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887
> docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53
> examples/vagrant/provision-aurora-scheduler.sh 87c369e864409b616980cc451109149d57635a74
> examples/vagrant/provision-dev-cluster.sh PRE-CREATION
> examples/vagrant/provision-dev-environment.sh 230691100ad68244290e6605c988606baeaa6890
> examples/vagrant/provision-mesos-master.sh 075d23d2dfa71521c3d739fe0eea5238de8c1a76
> examples/vagrant/provision-mesos-slave.sh f42b5c30d91e3d1e95f033001c31af37d6637948
> examples/vagrant/upstart/aurora-scheduler.conf PRE-CREATION
> examples/vagrant/upstart/aurora-thermos-observer.conf PRE-CREATION
> examples/vagrant/upstart/mesos-master.conf PRE-CREATION
> examples/vagrant/upstart/mesos-slave.conf PRE-CREATION
> examples/vagrant/upstart/zookeeper.conf PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19939/diff/
>
>
> Testing
> -------
>
> Followed (updated) docs/tutorial.md
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 19939: Use a single VM for the dev cluster,
manage processes with upstart.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19939/#review39339
-----------------------------------------------------------
Ship it!
docs/tutorial.md
<https://reviews.apache.org/r/19939/#comment71693>
Would it make sense to use devcluster instead of vagrant in the job key?
- Maxim Khutornenko
On April 2, 2014, 6:48 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19939/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 6:48 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> In the interest of speeding up development time in vagrant and improving accessibility to the vagrant development workflow, i've collapsed all VMs into one. This allows me to vagrant destroy/up in < 30 mins on my macbook air with a 1.6 GHz core 2 duo and 4 GB RAM. Prior to this change i could not run the vagrant environment, despite efforts to reduce the requirements of each machine.
>
> NOTE: Reviewboard has been consistently choking on applying the true diff. examples/vagrant/provision-zookeeper.sh reflects as unchanged in this diff, but i will be removing it before pushing the commit.
>
>
> Diffs
> -----
>
> Vagrantfile 52e2fff1a8011bb185e3a986fd30005d96257d05
> docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec
> docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887
> docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53
> examples/vagrant/provision-aurora-scheduler.sh 87c369e864409b616980cc451109149d57635a74
> examples/vagrant/provision-dev-cluster.sh PRE-CREATION
> examples/vagrant/provision-dev-environment.sh 230691100ad68244290e6605c988606baeaa6890
> examples/vagrant/provision-mesos-master.sh 075d23d2dfa71521c3d739fe0eea5238de8c1a76
> examples/vagrant/provision-mesos-slave.sh f42b5c30d91e3d1e95f033001c31af37d6637948
> examples/vagrant/upstart/aurora-scheduler.conf PRE-CREATION
> examples/vagrant/upstart/aurora-thermos-observer.conf PRE-CREATION
> examples/vagrant/upstart/mesos-master.conf PRE-CREATION
> examples/vagrant/upstart/mesos-slave.conf PRE-CREATION
> examples/vagrant/upstart/zookeeper.conf PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19939/diff/
>
>
> Testing
> -------
>
> Followed (updated) docs/tutorial.md
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 19939: Use a single VM for the dev cluster,
manage processes with upstart.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19939/
-----------------------------------------------------------
(Updated April 2, 2014, 10:51 p.m.)
Review request for Aurora, Jake Farrell, Kevin Sweeney, and Maxim Khutornenko.
Changes
-------
Fixup path discrepancies spotted in another pass through the tutorial.
Bugs: AURORA-299
https://issues.apache.org/jira/browse/AURORA-299
Repository: aurora
Description
-------
In the interest of speeding up development time in vagrant and improving accessibility to the vagrant development workflow, i've collapsed all VMs into one. This allows me to vagrant destroy/up in < 30 mins on my macbook air with a 1.6 GHz core 2 duo and 4 GB RAM. Prior to this change i could not run the vagrant environment, despite efforts to reduce the requirements of each machine.
NOTE: Reviewboard has been consistently choking on applying the true diff. examples/vagrant/provision-zookeeper.sh reflects as unchanged in this diff, but i will be removing it before pushing the commit.
Diffs (updated)
-----
Vagrantfile 52e2fff1a8011bb185e3a986fd30005d96257d05
docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec
docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887
docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53
examples/vagrant/provision-aurora-scheduler.sh 87c369e864409b616980cc451109149d57635a74
examples/vagrant/provision-dev-cluster.sh PRE-CREATION
examples/vagrant/provision-dev-environment.sh 230691100ad68244290e6605c988606baeaa6890
examples/vagrant/provision-mesos-master.sh 075d23d2dfa71521c3d739fe0eea5238de8c1a76
examples/vagrant/provision-mesos-slave.sh f42b5c30d91e3d1e95f033001c31af37d6637948
examples/vagrant/upstart/aurora-scheduler.conf PRE-CREATION
examples/vagrant/upstart/aurora-thermos-observer.conf PRE-CREATION
examples/vagrant/upstart/mesos-master.conf PRE-CREATION
examples/vagrant/upstart/mesos-slave.conf PRE-CREATION
examples/vagrant/upstart/zookeeper.conf PRE-CREATION
Diff: https://reviews.apache.org/r/19939/diff/
Testing
-------
Followed (updated) docs/tutorial.md
Thanks,
Bill Farner
Re: Review Request 19939: Use a single VM for the dev cluster,
manage processes with upstart.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19939/
-----------------------------------------------------------
(Updated April 2, 2014, 9:32 p.m.)
Review request for Aurora, Jake Farrell, Kevin Sweeney, and Maxim Khutornenko.
Changes
-------
added bug
Bugs: AURORA-299
https://issues.apache.org/jira/browse/AURORA-299
Repository: aurora
Description
-------
In the interest of speeding up development time in vagrant and improving accessibility to the vagrant development workflow, i've collapsed all VMs into one. This allows me to vagrant destroy/up in < 30 mins on my macbook air with a 1.6 GHz core 2 duo and 4 GB RAM. Prior to this change i could not run the vagrant environment, despite efforts to reduce the requirements of each machine.
NOTE: Reviewboard has been consistently choking on applying the true diff. examples/vagrant/provision-zookeeper.sh reflects as unchanged in this diff, but i will be removing it before pushing the commit.
Diffs
-----
Vagrantfile 52e2fff1a8011bb185e3a986fd30005d96257d05
docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec
docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887
docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53
examples/vagrant/provision-aurora-scheduler.sh 87c369e864409b616980cc451109149d57635a74
examples/vagrant/provision-dev-cluster.sh PRE-CREATION
examples/vagrant/provision-dev-environment.sh 230691100ad68244290e6605c988606baeaa6890
examples/vagrant/provision-mesos-master.sh 075d23d2dfa71521c3d739fe0eea5238de8c1a76
examples/vagrant/provision-mesos-slave.sh f42b5c30d91e3d1e95f033001c31af37d6637948
examples/vagrant/upstart/aurora-scheduler.conf PRE-CREATION
examples/vagrant/upstart/aurora-thermos-observer.conf PRE-CREATION
examples/vagrant/upstart/mesos-master.conf PRE-CREATION
examples/vagrant/upstart/mesos-slave.conf PRE-CREATION
examples/vagrant/upstart/zookeeper.conf PRE-CREATION
Diff: https://reviews.apache.org/r/19939/diff/
Testing
-------
Followed (updated) docs/tutorial.md
Thanks,
Bill Farner
Re: Review Request 19939: Use a single VM for the dev cluster,
manage processes with upstart.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19939/
-----------------------------------------------------------
(Updated April 2, 2014, 9:29 p.m.)
Review request for Aurora, Jake Farrell, Kevin Sweeney, and Maxim Khutornenko.
Changes
-------
Cluster name vagrant -> devcluster.
Repository: aurora
Description
-------
In the interest of speeding up development time in vagrant and improving accessibility to the vagrant development workflow, i've collapsed all VMs into one. This allows me to vagrant destroy/up in < 30 mins on my macbook air with a 1.6 GHz core 2 duo and 4 GB RAM. Prior to this change i could not run the vagrant environment, despite efforts to reduce the requirements of each machine.
NOTE: Reviewboard has been consistently choking on applying the true diff. examples/vagrant/provision-zookeeper.sh reflects as unchanged in this diff, but i will be removing it before pushing the commit.
Diffs (updated)
-----
Vagrantfile 52e2fff1a8011bb185e3a986fd30005d96257d05
docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec
docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887
docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53
examples/vagrant/provision-aurora-scheduler.sh 87c369e864409b616980cc451109149d57635a74
examples/vagrant/provision-dev-cluster.sh PRE-CREATION
examples/vagrant/provision-dev-environment.sh 230691100ad68244290e6605c988606baeaa6890
examples/vagrant/provision-mesos-master.sh 075d23d2dfa71521c3d739fe0eea5238de8c1a76
examples/vagrant/provision-mesos-slave.sh f42b5c30d91e3d1e95f033001c31af37d6637948
examples/vagrant/upstart/aurora-scheduler.conf PRE-CREATION
examples/vagrant/upstart/aurora-thermos-observer.conf PRE-CREATION
examples/vagrant/upstart/mesos-master.conf PRE-CREATION
examples/vagrant/upstart/mesos-slave.conf PRE-CREATION
examples/vagrant/upstart/zookeeper.conf PRE-CREATION
Diff: https://reviews.apache.org/r/19939/diff/
Testing
-------
Followed (updated) docs/tutorial.md
Thanks,
Bill Farner