You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mattisonchao (via GitHub)" <gi...@apache.org> on 2023/03/09 07:59:08 UTC

[GitHub] [pulsar] mattisonchao opened a new pull request, #19761: [fix][meta] Fix close borrowed executor

mattisonchao opened a new pull request, #19761:
URL: https://github.com/apache/pulsar/pull/19761

   ### Motivation
   
   The executor owner is `CoordinationServiceImpl `, but we close it in the borrower `LeaderElectionImpl`.
   
   ### Modifications
   
   - Don't close borrowed executor in `LeaderElectionImpl`
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] mattisonchao closed pull request #19761: [fix][meta] Fix close borrowed executor

Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao closed pull request #19761: [fix][meta] Fix close borrowed executor
URL: https://github.com/apache/pulsar/pull/19761


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codecov-commenter commented on pull request #19761: [fix][meta] Fix close borrowed executor

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19761:
URL: https://github.com/apache/pulsar/pull/19761#issuecomment-1463152768

   ## [Codecov](https://codecov.io/gh/apache/pulsar/pull/19761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19761](https://codecov.io/gh/apache/pulsar/pull/19761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ba3da9b) into [master](https://codecov.io/gh/apache/pulsar/commit/02b25a3b2461b975b46afdca4130cdba876721c0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (02b25a3) will **decrease** coverage by `31.61%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/19761/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/19761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #19761       +/-   ##
   =============================================
   - Coverage     62.35%   30.74%   -31.61%     
   + Complexity    25873      293    -25580     
   =============================================
     Files          1844     1672      -172     
     Lines        135280   126638     -8642     
     Branches      14875    13830     -1045     
   =============================================
   - Hits          84352    38937    -45415     
   - Misses        43183    81872    +38689     
   + Partials       7745     5829     -1916     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | inttests | `24.69% <46.66%> (+0.07%)` | :arrow_up: |
   | systests | `25.26% <60.00%> (-0.13%)` | :arrow_down: |
   | unittests | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...okkeeper/mledger/impl/ShadowManagedLedgerImpl.java](https://codecov.io/gh/apache/pulsar/pull/19761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL1NoYWRvd01hbmFnZWRMZWRnZXJJbXBsLmphdmE=) | `0.00% <0.00%> (-51.24%)` | :arrow_down: |
   | [...metadata/coordination/impl/LeaderElectionImpl.java](https://codecov.io/gh/apache/pulsar/pull/19761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLW1ldGFkYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvbWV0YWRhdGEvY29vcmRpbmF0aW9uL2ltcGwvTGVhZGVyRWxlY3Rpb25JbXBsLmphdmE=) | `53.54% <ø> (-15.49%)` | :arrow_down: |
   | [...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java](https://codecov.io/gh/apache/pulsar/pull/19761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRMZWRnZXJJbXBsLmphdmE=) | `44.54% <64.28%> (-34.33%)` | :arrow_down: |
   
   ... and [1273 files with indirect coverage changes](https://codecov.io/gh/apache/pulsar/pull/19761/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] mattisonchao closed pull request #19761: [fix][meta] Fix close borrowed executor

Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao closed pull request #19761: [fix][meta] Fix close borrowed executor
URL: https://github.com/apache/pulsar/pull/19761


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] mattisonchao closed pull request #19761: [fix][meta] Fix close borrowed executor

Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao closed pull request #19761: [fix][meta] Fix close borrowed executor
URL: https://github.com/apache/pulsar/pull/19761


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- commented on pull request #19761: [fix][meta] Fix close borrowed executor

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #19761:
URL: https://github.com/apache/pulsar/pull/19761#issuecomment-1465570931

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] mattisonchao closed pull request #19761: [fix][meta] Fix close borrowed executor

Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao closed pull request #19761: [fix][meta] Fix close borrowed executor
URL: https://github.com/apache/pulsar/pull/19761


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] mattisonchao closed pull request #19761: [fix][meta] Fix close borrowed executor

Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao closed pull request #19761: [fix][meta] Fix close borrowed executor
URL: https://github.com/apache/pulsar/pull/19761


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- merged pull request #19761: [fix][meta] Fix close borrowed executor

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #19761:
URL: https://github.com/apache/pulsar/pull/19761


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] mattisonchao closed pull request #19761: [fix][meta] Fix close borrowed executor

Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao closed pull request #19761: [fix][meta] Fix close borrowed executor
URL: https://github.com/apache/pulsar/pull/19761


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- commented on pull request #19761: [fix][meta] Fix close borrowed executor

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #19761:
URL: https://github.com/apache/pulsar/pull/19761#issuecomment-1467308122

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org