[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

["snuyanzin (via GitHub)" <gi...@apache.org>]

snuyanzin commented on code in PR #22558:
URL: https://github.com/apache/flink/pull/22558#discussion_r1190401612


##########
flink-table/flink-sql-parser/pom.xml:
##########
@@ -162,11 +163,6 @@ under the License.
 					<groupId>com.google.uzaygezen</groupId>
 					<artifactId>uzaygezen-core</artifactId>
 				</exclusion>
-				<!-- Excluding org.apiguardian:apiguardian-api v1.1.0 because org.junit.jupiter:junit-jupiter contains newer version v1.1.2 -->
-				<exclusion>
-					<groupId>org.apiguardian</groupId>
-					<artifactId>apiguardian-api</artifactId>
-				</exclusion>

Review Comment:
   Calcite 1.31.0 now depends on 1.1.2 api.guardian (same as junit-jupiter) and since the latest commit to api.guardian was about 2 years ago[1] it's pretty unlikely there will be new versions...
   
   [1] https://github.com/apiguardian-team/apiguardian



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org