You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/05/11 21:23:39 UTC
[GitHub] [yunikorn-k8shim] craigcondit opened a new pull request, #589: [YUNIKORN-1732] Fix Makefile calculation of SHA hashes
craigcondit opened a new pull request, #589:
URL: https://github.com/apache/yunikorn-k8shim/pull/589
### What is this PR for?
Fix the Makefile's calculation of SHA hashes for build components. The scripts used are brittle and fail if the output of `go list -m` doesn't fit the expected pattern (especially when replacing local dependencies).
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1732
### How should this be tested?
Build now succeeds where it failed previously and generates proper hashes.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #589: [YUNIKORN-1732] Fix Makefile calculation of SHA hashes
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #589:
URL: https://github.com/apache/yunikorn-k8shim/pull/589#issuecomment-1544715855
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#589](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/589?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6875655) into [master](https://app.codecov.io/gh/apache/yunikorn-k8shim/commit/0935a47ee43068332cafe9ca0b2e0344506e2837?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0935a47) will **increase** coverage by `69.99%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #589 +/- ##
===========================================
+ Coverage 0 69.99% +69.99%
===========================================
Files 0 47 +47
Lines 0 7948 +7948
===========================================
+ Hits 0 5563 +5563
- Misses 0 2177 +2177
- Partials 0 208 +208
```
[see 47 files with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/589/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #589: [YUNIKORN-1732] Fix Makefile calculation of SHA hashes
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #589: [YUNIKORN-1732] Fix Makefile calculation of SHA hashes
URL: https://github.com/apache/yunikorn-k8shim/pull/589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit commented on pull request #589: [YUNIKORN-1732] Fix Makefile calculation of SHA hashes
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on PR #589:
URL: https://github.com/apache/yunikorn-k8shim/pull/589#issuecomment-1546229038
> Proposal is to use this, removes all the field dependencies:
>
> ```
> go list -f '{{.Version}}' -m "github.com/apache/yunikorn-core" | cut -d "-" -f3`
> ```
Nice catch, have updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org