You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/29 21:01:37 UTC
[GitHub] [incubator-nuttx] daniel-p-carvalho opened a new pull request #4255: STM32 DAC Driver - Add support to DAC3
daniel-p-carvalho opened a new pull request #4255:
URL: https://github.com/apache/incubator-nuttx/pull/4255
## Summary
Add support to DAC3 for STM32G4 devices. The nucleo-g431kb:comp configuration was changed to use DAC3CH2 signal on
COMP2 inverting input. The voltage on inverting input can be changed using dac tool.
## Impact
## Testing
Tested on nucleo-g431kb board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] daniel-p-carvalho commented on a change in pull request #4255: STM32 DAC Driver - Add support to DAC3
Posted by GitBox <gi...@apache.org>.
daniel-p-carvalho commented on a change in pull request #4255:
URL: https://github.com/apache/incubator-nuttx/pull/4255#discussion_r681029375
##########
File path: arch/arm/src/stm32/Kconfig
##########
@@ -2027,6 +2026,7 @@ config STM32_STM32G43XX
config STM32_STM32G431K
bool
default n
+ select STM32_HAVE_DAC3
Review comment:
Yes, I will move the option as you suggested.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl merged pull request #4255: STM32 DAC Driver - Add support to DAC3
Posted by GitBox <gi...@apache.org>.
raiden00pl merged pull request #4255:
URL: https://github.com/apache/incubator-nuttx/pull/4255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] daniel-p-carvalho commented on pull request #4255: STM32 DAC Driver - Add support to DAC3
Posted by GitBox <gi...@apache.org>.
daniel-p-carvalho commented on pull request #4255:
URL: https://github.com/apache/incubator-nuttx/pull/4255#issuecomment-892865830
There is any update about this PR?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl merged pull request #4255: STM32 DAC Driver - Add support to DAC3
Posted by GitBox <gi...@apache.org>.
raiden00pl merged pull request #4255:
URL: https://github.com/apache/incubator-nuttx/pull/4255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #4255: STM32 DAC Driver - Add support to DAC3
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on a change in pull request #4255:
URL: https://github.com/apache/incubator-nuttx/pull/4255#discussion_r680701782
##########
File path: arch/arm/src/stm32/Kconfig
##########
@@ -2027,6 +2026,7 @@ config STM32_STM32G43XX
config STM32_STM32G431K
bool
default n
+ select STM32_HAVE_DAC3
Review comment:
Could you move this under STM32_STM32G43XX option ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] daniel-p-carvalho commented on a change in pull request #4255: STM32 DAC Driver - Add support to DAC3
Posted by GitBox <gi...@apache.org>.
daniel-p-carvalho commented on a change in pull request #4255:
URL: https://github.com/apache/incubator-nuttx/pull/4255#discussion_r681028532
##########
File path: boards/arm/stm32/nucleo-g431kb/src/stm32_dac.c
##########
@@ -80,6 +84,25 @@ int stm32_dac_setup(void)
return ret;
}
+#endif
+
+#ifdef CONFIG_STM32_DAC3CH2
+ g_dac5 = stm32_dacinitialize(5);
+ if (g_dac5 == NULL)
+ {
+ aerr("ERROR: Failed to get DAC interface\n");
+ return -ENODEV;
+ }
+
+ /* Register the DAC driver at "/dev/dac0" */
+
+ ret = dac_register("/dev/dac0", g_dac5);
Review comment:
You are right. I will change the register path of DAC3CH2 to "/dev/dac5".
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] daniel-p-carvalho commented on pull request #4255: STM32 DAC Driver - Add support to DAC3
Posted by GitBox <gi...@apache.org>.
daniel-p-carvalho commented on pull request #4255:
URL: https://github.com/apache/incubator-nuttx/pull/4255#issuecomment-892865830
There is any update about this PR?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4255: STM32 DAC Driver - Add support to DAC3
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #4255:
URL: https://github.com/apache/incubator-nuttx/pull/4255#discussion_r680531251
##########
File path: boards/arm/stm32/nucleo-g431kb/src/stm32_dac.c
##########
@@ -80,6 +84,25 @@ int stm32_dac_setup(void)
return ret;
}
+#endif
+
+#ifdef CONFIG_STM32_DAC3CH2
+ g_dac5 = stm32_dacinitialize(5);
+ if (g_dac5 == NULL)
+ {
+ aerr("ERROR: Failed to get DAC interface\n");
+ return -ENODEV;
+ }
+
+ /* Register the DAC driver at "/dev/dac0" */
+
+ ret = dac_register("/dev/dac0", g_dac5);
Review comment:
What will happen if CONFIG_STM32_DAC1CH1 and CONFIG_STM32_DAC3CH2 be defined? I think it will fail to register the second "/dev/dac0". I think you need to avoid it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org