[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #997: [CELEBORN-18] Refactor stream manager to distinguish map partition and reduce partition.

[GitBox <gi...@apache.org>]

RexXiong commented on code in PR #997:
URL: https://github.com/apache/incubator-celeborn/pull/997#discussion_r1032054984


##########
common/src/main/java/org/apache/celeborn/common/meta/FileInfo.java:
##########
@@ -28,24 +28,39 @@
 import org.apache.hadoop.fs.Path;
 
 import org.apache.celeborn.common.identity.UserIdentifier;
+import org.apache.celeborn.common.protocol.PartitionType;
 import org.apache.celeborn.common.util.Utils;
 
 public class FileInfo {
   private final String filePath;
   private final List<Long> chunkOffsets;
   private final UserIdentifier userIdentifier;
+  private final PartitionType partitionType;
 
   public FileInfo(String filePath, List<Long> chunkOffsets, UserIdentifier userIdentifier) {

Review Comment:
   suggest use this(filePath....)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org