You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/06 02:20:03 UTC

[GitHub] [flink] TisonKun opened a new pull request #10451: [FLINK-15086][client] Explictly close JobCluster in attach mode

TisonKun opened a new pull request #10451: [FLINK-15086][client] Explictly close JobCluster in attach mode
URL: https://github.com/apache/flink/pull/10451
 
 
   ## What is the purpose of the change
   
   If a JobCluster started in attached execution mode, it will wait for a client requesting its result and shutdown itself. However, there is no permission that a user get JobClient from executeAsync call getJobExecutionResult so the cluster may remain.
   
   Since currently the choice detach or attach can be done by user itself, my opinion is that we doesn't close JobCluster in MiniDispatcher in attach mode, but let the client send a shutdown request on close.
   
   ## Verifying this change
   
   Maybe an end-to-end test for resource leak? I don't have an idea to verify per-job resource leak in UT/IT framework.
   
   ## Does this pull request potentially affect one of the following parts:
   
   N/A
   
   ## Documentation
   
   N/A
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services