You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/12/02 21:27:29 UTC
[GitHub] [helix] kaisun2000 commented on a change in pull request #1532: Per replica throttle
kaisun2000 commented on a change in pull request #1532:
URL: https://github.com/apache/helix/pull/1532#discussion_r534492347
##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/IntermediateStateCalcStage.java
##########
@@ -483,7 +483,7 @@ private void chargePendingTransition(Resource resource, CurrentStateOutput curre
rebalanceType = StateTransitionThrottleConfig.RebalanceType.LOAD_BALANCE;
}
- if (pendingMap.size() > 0) {
+ if (pendingMap.size() > 0 && rebalanceType != RebalanceType.NONE) {
Review comment:
Agree. But this is a bug previously we have. It is also in production now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org