You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/07 16:24:00 UTC
[jira] [Commented] (MINIFICPP-340) EL extension contaminated with
boost
[ https://issues.apache.org/jira/browse/MINIFICPP-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282094#comment-16282094 ]
ASF GitHub Bot commented on MINIFICPP-340:
------------------------------------------
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/215
MINIFICPP-340 Remove unnecessary boost references
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-340
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/215.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #215
----
commit dfca656d91e18f9aa28abffcc9083e222b9f2fc4
Author: Andy I. Christianson <an...@andyic.org>
Date: 2017-12-07T16:22:46Z
MINIFICPP-340 Remove unnecessary boost references
----
> EL extension contaminated with boost
> ------------------------------------
>
> Key: MINIFICPP-340
> URL: https://issues.apache.org/jira/browse/MINIFICPP-340
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
>
> The EL extension doesn't rely on boost, but there are references to boost in the CMakeLists which need to be stripped out.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)