You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Jiangjie Qin <be...@gmail.com> on 2015/01/23 00:25:32 UTC

Review Request 30199: Patch for KAFKA-1890

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30199/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1890
    https://issues.apache.org/jira/browse/KAFKA-1890


Repository: kafka


Description
-------

Patch for KAFKA-1890


Diffs
-----

  core/src/main/scala/kafka/tools/MirrorMaker.scala 5cbc8103e33a0a234d158c048e5314e841da6249 

Diff: https://reviews.apache.org/r/30199/diff/


Testing
-------


Thanks,

Jiangjie Qin

Re: Review Request 30199: Patch for KAFKA-1890

Posted by Neha Narkhede <ne...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30199/#review69405
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On Jan. 23, 2015, 3:57 a.m., Jiangjie Qin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30199/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2015, 3:57 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1890
>     https://issues.apache.org/jira/browse/KAFKA-1890
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Patch for KAFKA-1890
> Mirror maker hit NPE at startup.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/tools/MirrorMaker.scala 5cbc8103e33a0a234d158c048e5314e841da6249 
> 
> Diff: https://reviews.apache.org/r/30199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jiangjie Qin
> 
>

Re: Review Request 30199: Patch for KAFKA-1890

Posted by Jiangjie Qin <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30199/
-----------------------------------------------------------

(Updated 一月 23, 2015, 3:57 a.m.)


Review request for kafka.


Bugs: KAFKA-1890
    https://issues.apache.org/jira/browse/KAFKA-1890


Repository: kafka


Description (updated)
-------

Patch for KAFKA-1890
Mirror maker hit NPE at startup.


Diffs
-----

  core/src/main/scala/kafka/tools/MirrorMaker.scala 5cbc8103e33a0a234d158c048e5314e841da6249 

Diff: https://reviews.apache.org/r/30199/diff/


Testing
-------


Thanks,

Jiangjie Qin

Re: Review Request 30199: Patch for KAFKA-1890

Posted by Jiangjie Qin <be...@gmail.com>.


> On 一月 23, 2015, 3:14 a.m., Joe Stein wrote:
> > Can you add test cases for the failure please? We should be able to apply the test cases, run test, see the failure, apply fix, verify the success. Thanks!

It was actually a pretty silly mistake I made. Mirror maker will always have NPE thrown out when starting up. After apply the patch it won't occur again.


- Jiangjie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30199/#review69337
-----------------------------------------------------------


On 一月 23, 2015, 3:57 a.m., Jiangjie Qin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30199/
> -----------------------------------------------------------
> 
> (Updated 一月 23, 2015, 3:57 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1890
>     https://issues.apache.org/jira/browse/KAFKA-1890
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Patch for KAFKA-1890
> Mirror maker hit NPE at startup.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/tools/MirrorMaker.scala 5cbc8103e33a0a234d158c048e5314e841da6249 
> 
> Diff: https://reviews.apache.org/r/30199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jiangjie Qin
> 
>

Re: Review Request 30199: Patch for KAFKA-1890

Posted by Joe Stein <cr...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30199/#review69337
-----------------------------------------------------------


Can you add test cases for the failure please? We should be able to apply the test cases, run test, see the failure, apply fix, verify the success. Thanks!

- Joe Stein


On Jan. 22, 2015, 11:25 p.m., Jiangjie Qin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30199/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 11:25 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1890
>     https://issues.apache.org/jira/browse/KAFKA-1890
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Patch for KAFKA-1890
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/tools/MirrorMaker.scala 5cbc8103e33a0a234d158c048e5314e841da6249 
> 
> Diff: https://reviews.apache.org/r/30199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jiangjie Qin
> 
>

Re: Review Request 30199: Patch for KAFKA-1890

Posted by Gwen Shapira <gs...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30199/#review69302
-----------------------------------------------------------

Ship it!


Ship It!

- Gwen Shapira


On Jan. 22, 2015, 11:25 p.m., Jiangjie Qin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30199/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 11:25 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1890
>     https://issues.apache.org/jira/browse/KAFKA-1890
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Patch for KAFKA-1890
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/tools/MirrorMaker.scala 5cbc8103e33a0a234d158c048e5314e841da6249 
> 
> Diff: https://reviews.apache.org/r/30199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jiangjie Qin
> 
>