You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/18 01:05:59 UTC
[GitHub] [druid] suneet-s opened a new pull request #9217: Minor doc updates
suneet-s opened a new pull request #9217: Minor doc updates
URL: https://github.com/apache/druid/pull/9217
Update kafka ingestion specs in tutorial docs to use the new inputSpec instead of parseSpec
Update first/ last aggregator docs to remove filterNullValues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #9217:
Minor doc updates
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #9217: Minor doc updates
URL: https://github.com/apache/druid/pull/9217#discussion_r368193322
##########
File path: examples/quickstart/tutorial/wikipedia-kafka-supervisor.json
##########
@@ -3,46 +3,46 @@
"spec" : {
"dataSchema": {
"dataSource": "wikipedia",
+ "timestampSpec": {
+ "column": "time",
+ "format": "auto"
+ },
+ "dimensionsSpec": {
+ "dimensions": [
+ "channel",
+ "cityName",
+ "comment",
+ "countryIsoCode",
+ "countryName",
+ "isAnonymous",
+ "isMinor",
+ "isNew",
+ "isRobot",
+ "isUnpatrolled",
+ "metroCode",
+ "namespace",
+ "page",
+ "regionIsoCode",
+ "regionName",
+ "user",
+ {
+ "name": "added",
+ "type": "long"
+ },
+ {
+ "name": "deleted",
+ "type": "long"
+ },
+ {
+ "name": "delta",
+ "type": "long"
+ }
+ ]
+ },
"parser": {
Review comment:
You can remove the `parser` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #9217: Minor
doc updates
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #9217: Minor doc updates
URL: https://github.com/apache/druid/pull/9217#discussion_r368193190
##########
File path: docs/querying/aggregations.md
##########
@@ -231,8 +230,7 @@ Note that queries with first/last aggregators on a segment created with rollup e
"type" : "stringLast",
"name" : <output_name>,
"fieldName" : <metric_name>,
- "maxStringBytes" : <integer> # (optional, defaults to 1024),
- "filterNullValues" : <boolean> # (optional, defaults to false)
+ "maxStringBytes" : <integer> # (optional, defaults to 1024)
}
Review comment:
FYI @maytasm3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei merged pull request #9217: Minor doc updates
Posted by GitBox <gi...@apache.org>.
jon-wei merged pull request #9217: Minor doc updates
URL: https://github.com/apache/druid/pull/9217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #9217: Minor
doc updates
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #9217: Minor doc updates
URL: https://github.com/apache/druid/pull/9217#discussion_r368195222
##########
File path: examples/quickstart/tutorial/wikipedia-kafka-supervisor.json
##########
@@ -3,46 +3,46 @@
"spec" : {
"dataSchema": {
"dataSource": "wikipedia",
+ "timestampSpec": {
+ "column": "time",
+ "format": "auto"
+ },
+ "dimensionsSpec": {
+ "dimensions": [
+ "channel",
+ "cityName",
+ "comment",
+ "countryIsoCode",
+ "countryName",
+ "isAnonymous",
+ "isMinor",
+ "isNew",
+ "isRobot",
+ "isUnpatrolled",
+ "metroCode",
+ "namespace",
+ "page",
+ "regionIsoCode",
+ "regionName",
+ "user",
+ {
+ "name": "added",
+ "type": "long"
+ },
+ {
+ "name": "deleted",
+ "type": "long"
+ },
+ {
+ "name": "delta",
+ "type": "long"
+ }
+ ]
+ },
"parser": {
Review comment:
🤦♂ done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm3 commented on a change in pull request #9217: Minor
doc updates
Posted by GitBox <gi...@apache.org>.
maytasm3 commented on a change in pull request #9217: Minor doc updates
URL: https://github.com/apache/druid/pull/9217#discussion_r368193808
##########
File path: docs/querying/aggregations.md
##########
@@ -231,8 +230,7 @@ Note that queries with first/last aggregators on a segment created with rollup e
"type" : "stringLast",
"name" : <output_name>,
"fieldName" : <metric_name>,
- "maxStringBytes" : <integer> # (optional, defaults to 1024),
- "filterNullValues" : <boolean> # (optional, defaults to false)
+ "maxStringBytes" : <integer> # (optional, defaults to 1024)
}
Review comment:
Thanks. Looks good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org