[GitHub] [spark] amaliujia commented on a diff in pull request #38200: [SPARK-40743][CONNECT]StructType should contain a list of StructField and each field should have a name

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38200:
URL: https://github.com/apache/spark/pull/38200#discussion_r991849673


##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -39,6 +39,38 @@ package object dsl {
               .addAllParts(identifier.asJava)
               .build())
           .build()
+
+      def protoQualifiedAttr: proto.Expression.QualifiedAttribute =
+        proto.Expression.QualifiedAttribute.newBuilder()
+          .setName(identifier.mkString("."))

Review Comment:
   For LocalRelation's attributes, how to convert `identifier: Seq[String]` to it? 
   
   Do we need to add an extra `qualifier: Seq[String]`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org