[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8054: [sql lab] persist tables list in localStorage

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #8054: [sql lab] persist tables list in localStorage
URL: https://github.com/apache/incubator-superset/pull/8054#discussion_r314535744
 
 

 ##########
 File path: superset/assets/src/SqlLab/utils/reduxStateToLocalStorageHelper.js
 ##########
 @@ -21,9 +21,11 @@ import { LOCALSTORAGE_MAX_QUERY_AGE_MS } from '../constants';
 const PERSISTENT_QUERY_EDITOR_KEYS = new Set([
   'autorun',
   'dbId',
+  'height',
 
 Review comment:
   this is used by sql editor resize function. if user resize editing area vs results area, this props saves user's setting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org