You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/10/02 08:52:34 UTC

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #869: porting/nimble/src/os_mempool - prevent possible NULL dereference

apache-mynewt-bot commented on pull request #869:
URL: https://github.com/apache/mynewt-nimble/pull/869#issuecomment-702608763


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### porting/nimble/src/os_mempool.c
   <details>
   
   ```diff
   @@ -106,7 +106,7 @@
            /* Chain the memory blocks to the free list */
            block_addr = (uint8_t *)membuf;
            block_ptr = (struct os_memblock *)block_addr;
   -        for (i =1; blocks > 1; i++) {
   +        for (i = 1; blocks > 1; i++) {
                block_addr += true_block_size;
                os_mempool_poison(block_addr, true_block_size);
                SLIST_NEXT(block_ptr, mb_next) = (struct os_memblock *)block_addr;
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org