You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/02 12:56:00 UTC
[jira] [Commented] (FLINK-9121) Remove Flip-6 prefixes from code
base
[ https://issues.apache.org/jira/browse/FLINK-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422225#comment-16422225 ]
ASF GitHub Bot commented on FLINK-9121:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5801
[FLINK-9121] [flip6] Remove Flip6 prefixes and other references
## What is the purpose of the change
Remove Flip6 prefixes and references to make Flip-6 the proper default:
Rename categories Flip6 -> New and OldAndFlip6 -> LegacyAndNew
Remove Flip-6 from documentation
Remove Flip-6 from start up scripts
## Verifying this change
- Covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink removeFlip6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5801.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5801
----
commit 82969a9fda2b8132abebf50b69d6bf0b055a97cd
Author: Till Rohrmann <tr...@...>
Date: 2018-04-02T09:13:57Z
[FLINK-9121] [flip6] Remove Flip6 prefixes and other references
Remove Flip6 prefixes and references to make Flip-6 the proper default:
Rename categories Flip6 -> New and OldAndFlip6 -> LegacyAndNew
Remove Flip-6 from documentation
Remove Flip-6 from start up scripts
----
> Remove Flip-6 prefixes from code base
> -------------------------------------
>
> Key: FLINK-9121
> URL: https://issues.apache.org/jira/browse/FLINK-9121
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: flip-6
> Fix For: 1.5.0
>
>
> We should remove all Flip-6 prefixes and other references from the code base since it is not a special case but the new default architecture. Instead we should prefix old code with legacy.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)