You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Yuki Morishita (JIRA)" <ji...@apache.org> on 2013/01/17 22:18:12 UTC

[jira] [Updated] (CASSANDRA-5151) Implement better way of eliminating compaction left overs.

     [ https://issues.apache.org/jira/browse/CASSANDRA-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yuki Morishita updated CASSANDRA-5151:
--------------------------------------

    Attachment: 5151-1.2.txt

Initial patch attached to get feedback. It writes compaction log file to track incomplete compactions described in my previous comment.

SSTable left-overs are deleted during node start up with CFS.scrubDataDirectories. In order to get ancestors of SSTable files, it has to deserialize each Stats.db file so slows down node startup, but this only happens when incomplete compaction left compaction log file.

The patch does not rely on CQL3 collection at all, so it is possible to port into 1.1.x.
                
> Implement better way of eliminating compaction left overs.
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-5151
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5151
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.1.3
>            Reporter: Yuki Morishita
>             Fix For: 1.2.1
>
>         Attachments: 5151-1.2.txt
>
>
> This is from discussion in CASSANDRA-5137. Currently we skip loading SSTables that are left over from incomplete compaction to not over-count counter, but the way we track compaction completion is not secure.
> One possible solution is to create system CF like:
> {code}
> create table compaction_log (
>   id uuid primary key,
>   inputs set<int>,
>   outputs set<int>
> );
> {code}
> to track incomplete compaction.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira