You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Brock Noland (Created) (JIRA)" <ji...@apache.org> on 2012/02/20 01:00:35 UTC
[jira] [Created] (FLUME-979) ExecSource should optionally restart
the command when it exits
ExecSource should optionally restart the command when it exits
--------------------------------------------------------------
Key: FLUME-979
URL: https://issues.apache.org/jira/browse/FLUME-979
Project: Flume
Issue Type: Improvement
Reporter: Brock Noland
Assignee: Brock Noland
At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234107#comment-13234107 ]
jiraposter@reviews.apache.org commented on FLUME-979:
-----------------------------------------------------
bq. On 2012-03-21 03:09:20, Arvind Prabhakar wrote:
bq. > Changes look good Brock. Some minor feedback:
bq. > * Please remove the extra whitespaces/tabs that are highlighted as red on the review
bq. >
done
bq. On 2012-03-21 03:09:20, Arvind Prabhakar wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java, line 211
bq. > <https://reviews.apache.org/r/3962/diff/3/?file=75933#file75933line211>
bq. >
bq. > Please create a ExecSourceConfigurationConstants class and declare these strings as public static final String CONFIG_RESTART_THROTTLE etc.
done
On 2012-03-21 03:09:20, Brock Noland wrote:
bq. > The patch will also need to be rebased on the trunk as the sources have changed a bit since the last time.
done
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3962/#review6159
-----------------------------------------------------------
On 2012-02-20 14:21:02, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3962/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-20 14:21:02)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. 1) Allows users to configure a restart flag and sleep interval for the ExecSource should the command exit.
bq. 2) Currently no one is reading standard error for the sub process. It is not ignored like the documentation suggests. If the command generates enough stderr to fill it's buffer, it will be blocked until someone reads that buffer. A thread is added which by default reads and throws away stderr. If a flag is turned on it will logstderr. This kind of flag can be very useful when debugging why a command is not outputting the expected data.
bq.
bq.
bq. This addresses bug FLUME-979.
bq. https://issues.apache.org/jira/browse/FLUME-979
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 3014368
bq. flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java a96016c
bq.
bq. Diff: https://reviews.apache.org/r/3962/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. A test for the restart flag and restartThrottle flag were added. All unit tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch, FLUME-979-1.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-979:
-------------------------------
Attachment: FLUME-979-2.patch
Latest patch
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch, FLUME-979-1.patch, FLUME-979-2.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211627#comment-13211627 ]
jiraposter@reviews.apache.org commented on FLUME-979:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3962/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
1) Allows users to configure a restart flag and sleep interval for the ExecSource should the command exit.
2) Currently no one is reading standard error for the sub process. It is not ignored like the documentation suggests. A thread is added which by default reads and throws away stderr. If a flag is turned on it will logstderr. This kind of flag can be very useful when debugging why a command is not outputting the expected data.
This addresses bug FLUME-979.
https://issues.apache.org/jira/browse/FLUME-979
Diffs
-----
flume-ng-core/pom.xml d753fa1
flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java a96016c
flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 3014368
Diff: https://reviews.apache.org/r/3962/diff
Testing
-------
A test for the restart flag and restartThrottle flag were added. All unit tests pass.
Thanks,
Brock
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-979:
-------------------------------
Status: Patch Available (was: Open)
Putting in "Patch Available" state.
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235008#comment-13235008 ]
jiraposter@reviews.apache.org commented on FLUME-979:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3962/#review6184
-----------------------------------------------------------
Ship it!
+1. Changes look good Brock. Please update the patch by removing the *.orig files from it. Also, it will be great if you could wrap the source lines that exceed 80 char limit.
No need for follow-up review, just attaching the patch to the Jira will be great. Thanks for all the help with this.
- Arvind
On 2012-03-21 05:13:45, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3962/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-21 05:13:45)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. 1) Allows users to configure a restart flag and sleep interval for the ExecSource should the command exit.
bq. 2) Currently no one is reading standard error for the sub process. It is not ignored like the documentation suggests. If the command generates enough stderr to fill it's buffer, it will be blocked until someone reads that buffer. A thread is added which by default reads and throws away stderr. If a flag is turned on it will logstderr. This kind of flag can be very useful when debugging why a command is not outputting the expected data.
bq.
bq.
bq. This addresses bug FLUME-979.
bq. https://issues.apache.org/jira/browse/FLUME-979
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java.orig PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java PRE-CREATION
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 6035270
bq. flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java.orig PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java b6b1181
bq.
bq. Diff: https://reviews.apache.org/r/3962/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. A test for the restart flag and restartThrottle flag were added. All unit tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch, FLUME-979-1.patch, FLUME-979-2.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-979:
-------------------------------
Attachment: FLUME-979-0.patch
Attached is the patch.
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211860#comment-13211860 ]
jiraposter@reviews.apache.org commented on FLUME-979:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3962/
-----------------------------------------------------------
(Updated 2012-02-20 14:21:02.192435)
Review request for Flume.
Changes
-------
Added note about reading stderr of a sub-process is required.
Summary (updated)
-------
1) Allows users to configure a restart flag and sleep interval for the ExecSource should the command exit.
2) Currently no one is reading standard error for the sub process. It is not ignored like the documentation suggests. If the command generates enough stderr to fill it's buffer, it will be blocked until someone reads that buffer. A thread is added which by default reads and throws away stderr. If a flag is turned on it will logstderr. This kind of flag can be very useful when debugging why a command is not outputting the expected data.
This addresses bug FLUME-979.
https://issues.apache.org/jira/browse/FLUME-979
Diffs
-----
flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 3014368
flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java a96016c
Diff: https://reviews.apache.org/r/3962/diff
Testing
-------
A test for the restart flag and restartThrottle flag were added. All unit tests pass.
Thanks,
Brock
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234106#comment-13234106 ]
jiraposter@reviews.apache.org commented on FLUME-979:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3962/
-----------------------------------------------------------
(Updated 2012-03-21 05:11:39.725708)
Review request for Flume.
Changes
-------
Updated patch based on comments and rebased to trunk.
Summary
-------
1) Allows users to configure a restart flag and sleep interval for the ExecSource should the command exit.
2) Currently no one is reading standard error for the sub process. It is not ignored like the documentation suggests. If the command generates enough stderr to fill it's buffer, it will be blocked until someone reads that buffer. A thread is added which by default reads and throws away stderr. If a flag is turned on it will logstderr. This kind of flag can be very useful when debugging why a command is not outputting the expected data.
This addresses bug FLUME-979.
https://issues.apache.org/jira/browse/FLUME-979
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java b6b1181
flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 6035270
Diff: https://reviews.apache.org/r/3962/diff
Testing
-------
A test for the restart flag and restartThrottle flag were added. All unit tests pass.
Thanks,
Brock
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch, FLUME-979-1.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234048#comment-13234048 ]
jiraposter@reviews.apache.org commented on FLUME-979:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3962/#review6159
-----------------------------------------------------------
Changes look good Brock. Some minor feedback:
* Please remove the extra whitespaces/tabs that are highlighted as red on the review
flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java
<https://reviews.apache.org/r/3962/#comment13244>
Please create a ExecSourceConfigurationConstants class and declare these strings as public static final String CONFIG_RESTART_THROTTLE etc.
The patch will also need to be rebased on the trunk as the sources have changed a bit since the last time.
- Arvind
On 2012-02-20 14:21:02, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3962/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-20 14:21:02)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. 1) Allows users to configure a restart flag and sleep interval for the ExecSource should the command exit.
bq. 2) Currently no one is reading standard error for the sub process. It is not ignored like the documentation suggests. If the command generates enough stderr to fill it's buffer, it will be blocked until someone reads that buffer. A thread is added which by default reads and throws away stderr. If a flag is turned on it will logstderr. This kind of flag can be very useful when debugging why a command is not outputting the expected data.
bq.
bq.
bq. This addresses bug FLUME-979.
bq. https://issues.apache.org/jira/browse/FLUME-979
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 3014368
bq. flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java a96016c
bq.
bq. Diff: https://reviews.apache.org/r/3962/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. A test for the restart flag and restartThrottle flag were added. All unit tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-979:
-------------------------------
Attachment: FLUME-979-1.patch
patch from RB
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch, FLUME-979-1.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211629#comment-13211629 ]
jiraposter@reviews.apache.org commented on FLUME-979:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3962/
-----------------------------------------------------------
(Updated 2012-02-20 01:37:42.014731)
Review request for Flume.
Changes
-------
Removed unneeded mockito change.
Summary
-------
1) Allows users to configure a restart flag and sleep interval for the ExecSource should the command exit.
2) Currently no one is reading standard error for the sub process. It is not ignored like the documentation suggests. A thread is added which by default reads and throws away stderr. If a flag is turned on it will logstderr. This kind of flag can be very useful when debugging why a command is not outputting the expected data.
This addresses bug FLUME-979.
https://issues.apache.org/jira/browse/FLUME-979
Diffs (updated)
-----
flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 3014368
flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java a96016c
Diff: https://reviews.apache.org/r/3962/diff
Testing
-------
A test for the restart flag and restartThrottle flag were added. All unit tests pass.
Thanks,
Brock
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-979:
-------------------------------
Attachment: FLUME-979-3.patch
Patch agreed upon on RB. Two lines are 81 chars as opposed to 80 but don't wrap well.
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch, FLUME-979-1.patch, FLUME-979-2.patch, FLUME-979-3.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-979:
-----------------------------------
Resolution: Fixed
Fix Version/s: v1.2.0
Status: Resolved (was: Patch Available)
Patch committed. Thanks Brock!
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: v1.2.0
>
> Attachments: FLUME-979-0.patch, FLUME-979-1.patch, FLUME-979-2.patch, FLUME-979-3.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234110#comment-13234110 ]
jiraposter@reviews.apache.org commented on FLUME-979:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3962/
-----------------------------------------------------------
(Updated 2012-03-21 05:13:45.221516)
Review request for Flume.
Changes
-------
For config class. Updated.
Summary
-------
1) Allows users to configure a restart flag and sleep interval for the ExecSource should the command exit.
2) Currently no one is reading standard error for the sub process. It is not ignored like the documentation suggests. If the command generates enough stderr to fill it's buffer, it will be blocked until someone reads that buffer. A thread is added which by default reads and throws away stderr. If a flag is turned on it will logstderr. This kind of flag can be very useful when debugging why a command is not outputting the expected data.
This addresses bug FLUME-979.
https://issues.apache.org/jira/browse/FLUME-979
Diffs (updated)
-----
flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java.orig PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java PRE-CREATION
flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 6035270
flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java.orig PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java b6b1181
Diff: https://reviews.apache.org/r/3962/diff
Testing
-------
A test for the restart flag and restartThrottle flag were added. All unit tests pass.
Thanks,
Brock
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-979-0.patch, FLUME-979-1.patch, FLUME-979-2.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-979) ExecSource should optionally restart
the command when it exits
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235392#comment-13235392 ]
Hudson commented on FLUME-979:
------------------------------
Integrated in flume-trunk #135 (See [https://builds.apache.org/job/flume-trunk/135/])
FLUME-979. ExecSource should optionally restart the command when it exits.
(Brock Noland via Arvind Prabhakar) (Revision 1303659)
Result = SUCCESS
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1303659
Files :
* /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java
* /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/ExecSourceConfigurationConstants.java
* /incubator/flume/trunk/flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
> ExecSource should optionally restart the command when it exits
> --------------------------------------------------------------
>
> Key: FLUME-979
> URL: https://issues.apache.org/jira/browse/FLUME-979
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: v1.2.0
>
> Attachments: FLUME-979-0.patch, FLUME-979-1.patch, FLUME-979-2.patch, FLUME-979-3.patch
>
>
> At present if the process executed by ExecSource dies, ExecSource stops emitting events.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira