You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/27 02:42:57 UTC

[GitHub] [pulsar] Nicklee007 commented on a diff in pull request #16189: [fix][broker] fix the incorrect swagger response parameter type

Nicklee007 commented on code in PR #16189:
URL: https://github.com/apache/pulsar/pull/16189#discussion_r906928236


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java:
##########
@@ -99,7 +98,7 @@ public void getClusters(@Suspended AsyncResponse asyncResponse) {
     @Path("/{cluster}")
     @ApiOperation(
         value = "Get the configuration for the specified cluster.",
-        response = ClusterDataImpl.class,
+        response = ClusterData.class,

Review Comment:
   the function return POJO is ClusterData.class but set in swagger is ClusterDataImpl.class and also will show to user the incorrect return type.  It will meet some error when we through restful api to invoke the method and want to transfer the result to ClusterData.class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org