You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2013/08/30 02:50:53 UTC
[1/3] git commit: Fixed os::chdir return value checking in
launcher.cpp.
Updated Branches:
refs/heads/master 6f7a4d745 -> 9bcdcca29
Fixed os::chdir return value checking in launcher.cpp.
From: Vinson Lee <vl...@freedesktop.org>
Review: https://reviews.apache.org/r/13880
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/bb5acfe3
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/bb5acfe3
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/bb5acfe3
Branch: refs/heads/master
Commit: bb5acfe3cff4af555b5d86878ad068b4b031d347
Parents: 6f7a4d7
Author: Benjamin Mahler <bm...@twitter.com>
Authored: Thu Aug 29 17:16:18 2013 -0700
Committer: Benjamin Mahler <bm...@twitter.com>
Committed: Thu Aug 29 17:16:18 2013 -0700
----------------------------------------------------------------------
src/launcher/launcher.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/bb5acfe3/src/launcher/launcher.cpp
----------------------------------------------------------------------
diff --git a/src/launcher/launcher.cpp b/src/launcher/launcher.cpp
index 7bf127a..6f2677a 100644
--- a/src/launcher/launcher.cpp
+++ b/src/launcher/launcher.cpp
@@ -135,7 +135,7 @@ int ExecutorLauncher::setup()
}
// Enter working directory.
- if (os::chdir(workDirectory) < 0) {
+ if (!os::chdir(workDirectory)) {
cerr << "Failed to chdir into executor work directory" << endl;
return -1;
}
@@ -160,7 +160,7 @@ int ExecutorLauncher::setup()
}
// Go back to previous directory.
- if (os::chdir(cwd) < 0) {
+ if (!os::chdir(cwd)) {
cerr << "Failed to chdir (back) into slave directory" << endl;
return -1;
}
[3/3] git commit: Fixed clang return-type build error in os::sendfile.
Posted by bm...@apache.org.
Fixed clang return-type build error in os::sendfile.
From: Vinson Lee <vl...@freedesktop.org>
Review: https://reviews.apache.org/r/13840
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/9bcdcca2
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/9bcdcca2
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/9bcdcca2
Branch: refs/heads/master
Commit: 9bcdcca29e65ba5e851fec413a50ef4127799e35
Parents: f94a93b
Author: Benjamin Mahler <bm...@twitter.com>
Authored: Thu Aug 29 17:18:05 2013 -0700
Committer: Benjamin Mahler <bm...@twitter.com>
Committed: Thu Aug 29 17:42:27 2013 -0700
----------------------------------------------------------------------
.../libprocess/3rdparty/stout/include/stout/os/sendfile.hpp | 5 +++++
1 file changed, 5 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/9bcdcca2/3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp b/3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp
index b41ba63..668e4da 100644
--- a/3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp
+++ b/3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp
@@ -12,6 +12,9 @@
#include <sys/uio.h>
#endif // __APPLE__
+#ifdef __linux__
+#include <stout/fatal.hpp>
+#endif // __linux__
#include <stout/os/signals.hpp>
namespace os {
@@ -30,6 +33,8 @@ inline ssize_t sendfile(int s, int fd, off_t offset, size_t length)
// This will set errno to EPIPE if a SIGPIPE occurs.
return ::sendfile(s, fd, &offset, length);
}
+ fatal("Unreachable statement");
+ return -1;
#elif defined __APPLE__
// On OS X, sendfile does not need to have SIGPIPE suppressed.
off_t _length = static_cast<off_t>(length);
[2/3] git commit: Fixed clang mismatched-tags errors in process.cpp.
Posted by bm...@apache.org.
Fixed clang mismatched-tags errors in process.cpp.
From: Vinson Lee <vl...@freedesktop.org>
Review: https://reviews.apache.org/r/13879
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/f94a93b1
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/f94a93b1
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/f94a93b1
Branch: refs/heads/master
Commit: f94a93b1b3ba52908cc77be77ff4eae925a39a3a
Parents: bb5acfe
Author: Benjamin Mahler <bm...@twitter.com>
Authored: Thu Aug 29 17:17:11 2013 -0700
Committer: Benjamin Mahler <bm...@twitter.com>
Committed: Thu Aug 29 17:17:11 2013 -0700
----------------------------------------------------------------------
3rdparty/libprocess/include/process/event.hpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/f94a93b1/3rdparty/libprocess/include/process/event.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/include/process/event.hpp b/3rdparty/libprocess/include/process/event.hpp
index 84a8790..cf728da 100644
--- a/3rdparty/libprocess/include/process/event.hpp
+++ b/3rdparty/libprocess/include/process/event.hpp
@@ -12,7 +12,7 @@
namespace process {
// Forward declarations.
-struct ProcessBase;
+class ProcessBase;
struct MessageEvent;
struct DispatchEvent;
struct HttpEvent;