You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mubarak Seyed (JIRA)" <ji...@apache.org> on 2011/08/05 23:08:31 UTC

[jira] [Created] (HBASE-4170) createTable java doc needs to be improved

createTable java doc needs to be improved
-----------------------------------------

                 Key: HBASE-4170
                 URL: https://issues.apache.org/jira/browse/HBASE-4170
             Project: HBase
          Issue Type: Improvement
          Components: regionserver
    Affects Versions: 0.90.1
         Environment: HBase-0.90.1
            Reporter: Mubarak Seyed
             Fix For: 0.90.1


HBaseAdmin.createTable() java doc says

public void createTable(HTableDescriptor desc,
                        byte[][] splitKeys)
                 throws IOException
Creates a new table with an initial set of empty regions defined by the specified split keys. The total number of regions created will be the number of split keys plus one (the first region has a null start key and the last region has a null end key). Synchronous operation.

If we specify null values for first region start key and last region end key, geting NullPointerException as Arrays.sort compares each element.
I guess the documentation should not talk about null values and explain about splitKeys[][] length as n-1, where n is number of regions.

splitKeys[][] would look like

splitKeys[0] = "key value 1"

..

splitKeys[n-1] = "key value n-1"

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4170) createTable java doc needs to be improved

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084733#comment-13084733 ] 

Hudson commented on HBASE-4170:
-------------------------------

Integrated in HBase-TRUNK #2113 (See [https://builds.apache.org/job/HBase-TRUNK/2113/])
    HBASE-4170 createTable java doc needs to be improved

stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/CHANGES.txt


> createTable java doc needs to be improved
> -----------------------------------------
>
>                 Key: HBASE-4170
>                 URL: https://issues.apache.org/jira/browse/HBASE-4170
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3, 0.90.4
>         Environment: HBase-0.90.1
>            Reporter: Mubarak Seyed
>            Assignee: Mubarak Seyed
>             Fix For: 0.90.5
>
>         Attachments: create_table_javadoc_HBASE_4170.patch
>
>
> HBaseAdmin.createTable() java doc says
> public void createTable(HTableDescriptor desc,
>                         byte[][] splitKeys)
>                  throws IOException
> Creates a new table with an initial set of empty regions defined by the specified split keys. The total number of regions created will be the number of split keys plus one (the first region has a null start key and the last region has a null end key). Synchronous operation.
> If we specify null values for first region start key and last region end key, geting NullPointerException as Arrays.sort compares each element.
> I guess the documentation should not talk about null values and explain about splitKeys[][] length as n-1, where n is number of regions.
> splitKeys[][] would look like
> splitKeys[0] = "key value 1"
> ..
> splitKeys[n-1] = "key value n-1"

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4170) createTable java doc needs to be improved

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-4170:
-------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 0.90.1)
                   0.90.5
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

Committed to branch and trunk.  Thanks for the patch Mubarak.

> createTable java doc needs to be improved
> -----------------------------------------
>
>                 Key: HBASE-4170
>                 URL: https://issues.apache.org/jira/browse/HBASE-4170
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3, 0.90.4
>         Environment: HBase-0.90.1
>            Reporter: Mubarak Seyed
>             Fix For: 0.90.5
>
>         Attachments: create_table_javadoc_HBASE_4170.patch
>
>
> HBaseAdmin.createTable() java doc says
> public void createTable(HTableDescriptor desc,
>                         byte[][] splitKeys)
>                  throws IOException
> Creates a new table with an initial set of empty regions defined by the specified split keys. The total number of regions created will be the number of split keys plus one (the first region has a null start key and the last region has a null end key). Synchronous operation.
> If we specify null values for first region start key and last region end key, geting NullPointerException as Arrays.sort compares each element.
> I guess the documentation should not talk about null values and explain about splitKeys[][] length as n-1, where n is number of regions.
> splitKeys[][] would look like
> splitKeys[0] = "key value 1"
> ..
> splitKeys[n-1] = "key value n-1"

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HBASE-4170) createTable java doc needs to be improved

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu reassigned HBASE-4170:
-----------------------------

    Assignee: Mubarak Seyed

> createTable java doc needs to be improved
> -----------------------------------------
>
>                 Key: HBASE-4170
>                 URL: https://issues.apache.org/jira/browse/HBASE-4170
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3, 0.90.4
>         Environment: HBase-0.90.1
>            Reporter: Mubarak Seyed
>            Assignee: Mubarak Seyed
>             Fix For: 0.90.5
>
>         Attachments: create_table_javadoc_HBASE_4170.patch
>
>
> HBaseAdmin.createTable() java doc says
> public void createTable(HTableDescriptor desc,
>                         byte[][] splitKeys)
>                  throws IOException
> Creates a new table with an initial set of empty regions defined by the specified split keys. The total number of regions created will be the number of split keys plus one (the first region has a null start key and the last region has a null end key). Synchronous operation.
> If we specify null values for first region start key and last region end key, geting NullPointerException as Arrays.sort compares each element.
> I guess the documentation should not talk about null values and explain about splitKeys[][] length as n-1, where n is number of regions.
> splitKeys[][] would look like
> splitKeys[0] = "key value 1"
> ..
> splitKeys[n-1] = "key value n-1"

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4170) createTable java doc needs to be improved

Posted by "Mubarak Seyed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mubarak Seyed updated HBASE-4170:
---------------------------------

    Attachment: create_table_javadoc_HBASE_4170.patch

The attached file is a patch for createTable java doc.

> createTable java doc needs to be improved
> -----------------------------------------
>
>                 Key: HBASE-4170
>                 URL: https://issues.apache.org/jira/browse/HBASE-4170
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3, 0.90.4
>         Environment: HBase-0.90.1
>            Reporter: Mubarak Seyed
>             Fix For: 0.90.1
>
>         Attachments: create_table_javadoc_HBASE_4170.patch
>
>
> HBaseAdmin.createTable() java doc says
> public void createTable(HTableDescriptor desc,
>                         byte[][] splitKeys)
>                  throws IOException
> Creates a new table with an initial set of empty regions defined by the specified split keys. The total number of regions created will be the number of split keys plus one (the first region has a null start key and the last region has a null end key). Synchronous operation.
> If we specify null values for first region start key and last region end key, geting NullPointerException as Arrays.sort compares each element.
> I guess the documentation should not talk about null values and explain about splitKeys[][] length as n-1, where n is number of regions.
> splitKeys[][] would look like
> splitKeys[0] = "key value 1"
> ..
> splitKeys[n-1] = "key value n-1"

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4170) createTable java doc needs to be improved

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081860#comment-13081860 ] 

stack commented on HBASE-4170:
------------------------------

Would you mind making a patch Mubarak?  Thank you.

> createTable java doc needs to be improved
> -----------------------------------------
>
>                 Key: HBASE-4170
>                 URL: https://issues.apache.org/jira/browse/HBASE-4170
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.90.1
>         Environment: HBase-0.90.1
>            Reporter: Mubarak Seyed
>             Fix For: 0.90.1
>
>
> HBaseAdmin.createTable() java doc says
> public void createTable(HTableDescriptor desc,
>                         byte[][] splitKeys)
>                  throws IOException
> Creates a new table with an initial set of empty regions defined by the specified split keys. The total number of regions created will be the number of split keys plus one (the first region has a null start key and the last region has a null end key). Synchronous operation.
> If we specify null values for first region start key and last region end key, geting NullPointerException as Arrays.sort compares each element.
> I guess the documentation should not talk about null values and explain about splitKeys[][] length as n-1, where n is number of regions.
> splitKeys[][] would look like
> splitKeys[0] = "key value 1"
> ..
> splitKeys[n-1] = "key value n-1"

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4170) createTable java doc needs to be improved

Posted by "Mubarak Seyed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mubarak Seyed updated HBASE-4170:
---------------------------------

    Status: Patch Available  (was: Open)

> createTable java doc needs to be improved
> -----------------------------------------
>
>                 Key: HBASE-4170
>                 URL: https://issues.apache.org/jira/browse/HBASE-4170
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.90.4, 0.90.3, 0.90.2, 0.90.1
>         Environment: HBase-0.90.1
>            Reporter: Mubarak Seyed
>             Fix For: 0.90.1
>
>
> HBaseAdmin.createTable() java doc says
> public void createTable(HTableDescriptor desc,
>                         byte[][] splitKeys)
>                  throws IOException
> Creates a new table with an initial set of empty regions defined by the specified split keys. The total number of regions created will be the number of split keys plus one (the first region has a null start key and the last region has a null end key). Synchronous operation.
> If we specify null values for first region start key and last region end key, geting NullPointerException as Arrays.sort compares each element.
> I guess the documentation should not talk about null values and explain about splitKeys[][] length as n-1, where n is number of regions.
> splitKeys[][] would look like
> splitKeys[0] = "key value 1"
> ..
> splitKeys[n-1] = "key value n-1"

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4170) createTable java doc needs to be improved

Posted by "Mubarak Seyed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mubarak Seyed updated HBASE-4170:
---------------------------------

    Affects Version/s: 0.90.2
                       0.90.3
                       0.90.4

> createTable java doc needs to be improved
> -----------------------------------------
>
>                 Key: HBASE-4170
>                 URL: https://issues.apache.org/jira/browse/HBASE-4170
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3, 0.90.4
>         Environment: HBase-0.90.1
>            Reporter: Mubarak Seyed
>             Fix For: 0.90.1
>
>
> HBaseAdmin.createTable() java doc says
> public void createTable(HTableDescriptor desc,
>                         byte[][] splitKeys)
>                  throws IOException
> Creates a new table with an initial set of empty regions defined by the specified split keys. The total number of regions created will be the number of split keys plus one (the first region has a null start key and the last region has a null end key). Synchronous operation.
> If we specify null values for first region start key and last region end key, geting NullPointerException as Arrays.sort compares each element.
> I guess the documentation should not talk about null values and explain about splitKeys[][] length as n-1, where n is number of regions.
> splitKeys[][] would look like
> splitKeys[0] = "key value 1"
> ..
> splitKeys[n-1] = "key value n-1"

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4170) createTable java doc needs to be improved

Posted by "Mubarak Seyed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mubarak Seyed updated HBASE-4170:
---------------------------------

    Component/s:     (was: regionserver)
                 client

> createTable java doc needs to be improved
> -----------------------------------------
>
>                 Key: HBASE-4170
>                 URL: https://issues.apache.org/jira/browse/HBASE-4170
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.90.1, 0.90.2, 0.90.3, 0.90.4
>         Environment: HBase-0.90.1
>            Reporter: Mubarak Seyed
>             Fix For: 0.90.1
>
>
> HBaseAdmin.createTable() java doc says
> public void createTable(HTableDescriptor desc,
>                         byte[][] splitKeys)
>                  throws IOException
> Creates a new table with an initial set of empty regions defined by the specified split keys. The total number of regions created will be the number of split keys plus one (the first region has a null start key and the last region has a null end key). Synchronous operation.
> If we specify null values for first region start key and last region end key, geting NullPointerException as Arrays.sort compares each element.
> I guess the documentation should not talk about null values and explain about splitKeys[][] length as n-1, where n is number of regions.
> splitKeys[][] would look like
> splitKeys[0] = "key value 1"
> ..
> splitKeys[n-1] = "key value n-1"

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira