You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "samueleresca (via GitHub)" <gi...@apache.org> on 2025/09/12 20:08:17 UTC
[PR] Trying cargo machete to prune unused deps. [datafusion]
samueleresca opened a new pull request, #17545:
URL: https://github.com/apache/datafusion/pull/17545
Very much a test with `cargo machete` to understand all the false positives detected by the tooling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Trying cargo machete to prune unused deps. [datafusion]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #17545:
URL: https://github.com/apache/datafusion/pull/17545#issuecomment-3291658641
> Anything else you think we should do with this PR @samueleresca ? I marked it ready for review as it looked great
Thanks 😄 I think we can proceed with this PR. I might open another PR for including cargo machete checks in CI. Full discussion in: https://github.com/apache/datafusion/issues/17550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Trying cargo machete to prune unused deps. [datafusion]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on code in PR #17545:
URL: https://github.com/apache/datafusion/pull/17545#discussion_r2348332580
##########
datafusion/datasource/Cargo.toml:
##########
@@ -31,7 +31,7 @@ version.workspace = true
all-features = true
[features]
-parquet = ["dep:parquet", "tempfile"]
+parquet = ["tempfile"]
Review Comment:
Proceeding by removing the `parquet` feature. Reasoning:
- `tempfile` is already included as part of the dependencies.
- There isn't any conditional code linked to the `parquet` features.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Trying cargo machete to prune unused deps. [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17545:
URL: https://github.com/apache/datafusion/pull/17545#issuecomment-3293907144
> > Anything else you think we should do with this PR @samueleresca ? I marked it ready for review as it looked great
>
> Thanks 😄 I think we can proceed with this PR. I might open another PR for including cargo machete checks in CI. Full discussion in: #17550
Thanks @samueleresca
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Trying cargo machete to prune unused deps. [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17545:
URL: https://github.com/apache/datafusion/pull/17545#issuecomment-3289468282
Anything else you think we should do with this PR @samueleresca ? I marked it ready for review as it looked great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Trying cargo machete to prune unused deps. [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #17545:
URL: https://github.com/apache/datafusion/pull/17545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Trying cargo machete to prune unused deps. [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on code in PR #17545:
URL: https://github.com/apache/datafusion/pull/17545#discussion_r2347296941
##########
datafusion/datasource/Cargo.toml:
##########
@@ -31,7 +31,7 @@ version.workspace = true
all-features = true
[features]
-parquet = ["dep:parquet", "tempfile"]
+parquet = ["tempfile"]
Review Comment:
I guess remove parquet feature from here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Trying cargo machete to prune unused deps. [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17545:
URL: https://github.com/apache/datafusion/pull/17545#issuecomment-3289467531
Looks like the experiment was a success ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org