You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/14 01:10:06 UTC

[GitHub] jihoonson commented on issue #7036: [Proposal] K-Way Merge for Time-Ordered Scans

jihoonson commented on issue #7036: [Proposal] K-Way Merge for Time-Ordered Scans
URL: https://github.com/apache/incubator-druid/issues/7036#issuecomment-463443019
 
 
   Nice proposal! I have some questions/comments.
   
   > This runner would open each segment file, perform a k-way merge on the files, and return a `Sequence` of 1-event `ScanResultValues`.
   
   Does this mean, the merged result in historicals would be a sequence of a single `ScanResultValue` which contains all time-ordered events of input segments? I understand the merge needs to block for sorting, but how does it work with stream merge in the broker? I guess the broker would also wait until it gets all events in `ScanResultValue`?
   
   > Alternatively, to avoid creating a new `QueryRunnerFactory` the existing query runner can check the `ScanQuery` object's limit and ordering, and decide what runner to provide in the `mergeRunners()` function.
   
   I think this is better than adding a new QueryRunnerFactory to minimize the complexity.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org