You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/08/22 22:08:31 UTC

[GitHub] [incubator-iotdb] ope-nz opened a new issue #1645: JDBC - createCompleteSql logging (info -> debug)

ope-nz opened a new issue #1645:
URL: https://github.com/apache/incubator-iotdb/issues/1645


   I am pushing data into iotdb via JDBC. The createCompleteSql function currently logs at the "info" level so every single SQL insert statement is being logged by default.
   
   Can I please request this logging is changed to the "debug" level?
   
   private String createCompleteSql(final String sql, Map<Integer, String> parameters)
   ...
         LoggerFactory.getLogger(IoTDBPreparedStatement.class).**info**("SQL {}",sql);
         LoggerFactory.getLogger(IoTDBPreparedStatement.class).**info**("parameters {}",parameters.size());
   ...
   
     }


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] qiaojialin commented on issue #1645: JDBC - createCompleteSql logging (info -> debug)

Posted by GitBox <gi...@apache.org>.
qiaojialin commented on issue #1645:
URL: https://github.com/apache/incubator-iotdb/issues/1645#issuecomment-679081763


   You can fetch the latest master branch. Besides, I recommend using the native API (Session and SessionPool), which is more efficient.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] qiaojialin commented on issue #1645: JDBC - createCompleteSql logging (info -> debug)

Posted by GitBox <gi...@apache.org>.
qiaojialin commented on issue #1645:
URL: https://github.com/apache/incubator-iotdb/issues/1645#issuecomment-678982702


   Sure~ Thanks for your feedback.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] qiaojialin closed issue #1645: JDBC - createCompleteSql logging (info -> debug)

Posted by GitBox <gi...@apache.org>.
qiaojialin closed issue #1645:
URL: https://github.com/apache/incubator-iotdb/issues/1645


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-iotdb] ope-nz commented on issue #1645: JDBC - createCompleteSql logging (info -> debug)

Posted by GitBox <gi...@apache.org>.
ope-nz commented on issue #1645:
URL: https://github.com/apache/incubator-iotdb/issues/1645#issuecomment-679370884


   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org