[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #4699: Support Alter Table Clause For External Table

[GitBox <gi...@apache.org>]

wuyunfeng commented on a change in pull request #4699:
URL: https://github.com/apache/incubator-doris/pull/4699#discussion_r502762167



##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java
##########
@@ -377,6 +408,17 @@ private void processRename(Database db, OlapTable table, List<AlterClause> alter
         }
     }
 
+    private void processRename(Database db, Table table, List<AlterClause> alterClauses) throws DdlException {

Review comment:
       ```suggestion
       private void processRenameAlterOperation(Database db, Table table, List<AlterClause> alterClauses) throws DdlException {
   ```

##########
File path: fe/fe-core/src/main/java/org/apache/doris/persist/OperationType.java
##########
@@ -182,4 +182,7 @@
     // resource 276~290
     public static final short OP_CREATE_RESOURCE = 276;
     public static final short OP_DROP_RESOURCE = 277;
+
+    // alter external table
+    public static final short OP_REFRESH_EXTERNAL_TABLE_SCHEMA = 280;

Review comment:
       just puzzled with the `refresh`?

##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -132,6 +132,26 @@ private void processAddColumn(AddColumnClause alterClause, OlapTable olapTable,
                           indexSchemaMap, newColNameSet);
     }
 
+    private void processAddColumn(AddColumnClause alterClause, Table externalTable, List<Column> newSchema) throws DdlException {

Review comment:
       ```suggestion
       private void processAddCol{Alter}Operation(AddColumnClause alterClause, Table externalTable, List<Column> newSchema) throws DdlException {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org