You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2006/04/18 11:48:54 UTC
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Stepan,
Just curious what you are fixing here? Changing 8 spaces to tabs?
Why does this matter? Shouldn't tabs (at the beginning of a line)
always be equivalent to 8 spaces?
Incidentally, I think 8 character indentations are excessive. Quite a
few of the ant files use 4 character indentations which I find much
easier to read. Ditto for java code. Perhaps we could agree which to
use?
Regards,
-Mark - wondering if he might regret asking this
On 4/18/06, smishura@apache.org <sm...@apache.org> wrote:
> Author: smishura
> Date: Tue Apr 18 02:38:29 2006
> New Revision: 394890
>
> URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
> Log:
> Correcting indentation
>
> Modified:
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
> incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
>
> Modified: incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> URL: http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
> ==============================================================================
> --- incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml (original)
> +++ incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml Tue Apr 18 02:38:29 2006
> @@ -68,12 +68,12 @@
>
>
> <target name="run.tests">
> -
> - <mkdir dir="${hy.tests.reports}" />
> +
> + <mkdir dir="${hy.tests.reports}" />
>
> <property name="test.jre.home" value="${hy.target}/jre" />
>
> - <junit fork="yes"
> + <junit fork="yes"
> forkmode="once"
> printsummary="withOutAndErr"
> errorproperty="test.errors"
>
> [ SNIP ]
--
Mark Hindess <ma...@googlemail.com>
IBM Java Technology Centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules:
applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/
beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/
luni/make/commo
Posted by Etienne Gagnon <eg...@sablevm.org>.
+1 too.
Mikhail Loenko wrote:
> +1
>
> 2006/4/18, Geir Magnusson Jr <ge...@pobox.com>:
>
>>Wait - no tabs! no tabs! PLEASE!
>>
>>You can have your 1,743 character test case names if you want, but NO
>>TABS! :)
--
Etienne M. Gagnon, Ph.D. http://www.info2.uqam.ca/~egagnon/
SableVM: http://www.sablevm.org/
SableCC: http://www.sablecc.org/
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Posted by Mikhail Loenko <ml...@gmail.com>.
+1
2006/4/18, Geir Magnusson Jr <ge...@pobox.com>:
> Wait - no tabs! no tabs! PLEASE!
>
> You can have your 1,743 character test case names if you want, but NO
> TABS! :)
>
> geir
>
> Mark Hindess wrote:
> > Stepan,
> >
> > Just curious what you are fixing here? Changing 8 spaces to tabs?
> > Why does this matter? Shouldn't tabs (at the beginning of a line)
> > always be equivalent to 8 spaces?
> >
> > Incidentally, I think 8 character indentations are excessive. Quite a
> > few of the ant files use 4 character indentations which I find much
> > easier to read. Ditto for java code. Perhaps we could agree which to
> > use?
> >
> > Regards,
> > -Mark - wondering if he might regret asking this
> >
> > On 4/18/06, smishura@apache.org <sm...@apache.org> wrote:
> >> Author: smishura
> >> Date: Tue Apr 18 02:38:29 2006
> >> New Revision: 394890
> >>
> >> URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
> >> Log:
> >> Correcting indentation
> >>
> >> Modified:
> >> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
> >> incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
> >>
> >> Modified: incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> >> URL: http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
> >> ==============================================================================
> >> --- incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml (original)
> >> +++ incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml Tue Apr 18 02:38:29 2006
> >> @@ -68,12 +68,12 @@
> >>
> >>
> >> <target name="run.tests">
> >> -
> >> - <mkdir dir="${hy.tests.reports}" />
> >> +
> >> + <mkdir dir="${hy.tests.reports}" />
> >>
> >> <property name="test.jre.home" value="${hy.target}/jre" />
> >>
> >> - <junit fork="yes"
> >> + <junit fork="yes"
> >> forkmode="once"
> >> printsummary="withOutAndErr"
> >> errorproperty="test.errors"
> >>
> >> [ SNIP ]
> >
> > --
> > Mark Hindess <ma...@googlemail.com>
> > IBM Java Technology Centre, UK.
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
RE: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Posted by Nathan Beyer <nb...@kc.rr.com>.
Correct, you can use the Ant formatter, or if you get the Web Tools code,
there's first-class XML editor that has its own formatting policies as well.
-Nathan
> -----Original Message-----
> From: Ivan Popov [mailto:ivan.g.popov@gmail.com]
> Sent: Wednesday, April 19, 2006 6:22 AM
> To: harmony-dev@incubator.apache.org
> Subject: Re: svn commit: r394890 - in
> /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/
> archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/
> crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
>
> By default Eclipse uses its own "Eclipse [built-in]" formatter for
> Java code, which inserts tabs for indentations\. However, it's
> possible to configure it to use spaces, or just choose "Java
> convetions [built-in]" formatter, which uses spaces by default. Just
> go "Window->Preferences->Java->Code Style->Formatter" page, select
> desired formatter, press "Show" button and set appropriate indentation
> policy and tab size. I think there is no need for a special formatter.
>
> AFAIK, for XML sources Eclipse uses Ant editor by default, which also
> uses tabs for indentation. It is possible to configure it to use
> spaces, just go to "Window->Preferences->Ant->Editor->Formatter" page
> and uncheck box "Use tab character insted of spaces".
>
> The problem might be that the new formatter settings will be applied
> only to the newly typed text. To apply it to existing sources one need
> to reformat text using "Format" or "Correct indentation" commands in
> editor view.
>
> Thanks.
> Ivan Popov
> Intel Middleware Products Division
>
> -------------
>
> On 4/19/06, Geir Magnusson Jr <ge...@pobox.com> wrote:
> > What does a "formatter profile" do? (I tend to use IDEA more than
> > Eclipse - comes from being a Mac user for so many years, where Eclipse
> > was utterly unusable until recently...) I assume the same-ish as a code
> > style in IDEA?
> >
> > In IDEA, by default "use tabs" is unchecked in the global code style of
> > the project code style with a tab size of 4. (IOW, tab key turns into 4
> > chars...)
> >
> > geir
> >
> >
> > Nathan Beyer wrote:
> > > For those who use Eclipse, this is fairly trivial to do with the Java
> > > editor. I've created a Formatter Profile (and tried to attach it),
> that can
> > > be imported and should setup this style of formatting.
> > >
> > > If you have the Web Tools, a similar format can be created for XML
> files as
> > > well.
> > >
> > > -Nathan
> > >
> > >> -----Original Message-----
> > >> From: Geir Magnusson Jr [mailto:geir@pobox.com]
> > >> Sent: Tuesday, April 18, 2006 7:01 AM
> > >> To: harmony-dev@incubator.apache.org
> > >> Subject: Re: svn commit: r394890 - in
> > >> /incubator/harmony/enhanced/classlib/trunk/modules:
> applet/make/common/
> > >> archive/make/common/ auth/make/common/ awt/make/common/
> beans/make/common/
> > >> crypto/make/common/ jndi/make/common/ logging/make/common/
> luni/make/commo
> > >>
> > >>
> > >>
> > >> Richard Liang wrote:
> > >>> Geir Magnusson Jr wrote:
> > >>>> Wait - no tabs! no tabs! PLEASE!
> > >>> +1. But are there any way to release our pain from TABs? :-)
> > >> Yes - most editors will convert tabs to spaces. I suppose if we
> agree
> > >> on a "no tabs" rule, and find files w/ tabs, lets do a conversion,
> and
> > >> check it in w/o any other mods, with the commit log entry of
> "changing
> > >> tabs to spaces" or such....
> > >>
> > >> geir
> > >>
> > >>
> > >> ---------------------------------------------------------------------
> ---
> > >>
> > >> ---------------------------------------------------------------------
> > >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > >> For additional commands, e-mail: harmony-dev-
> help@incubator.apache.org
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Posted by Ivan Popov <iv...@gmail.com>.
By default Eclipse uses its own "Eclipse [built-in]" formatter for
Java code, which inserts tabs for indentations\. However, it's
possible to configure it to use spaces, or just choose "Java
convetions [built-in]" formatter, which uses spaces by default. Just
go "Window->Preferences->Java->Code Style->Formatter" page, select
desired formatter, press "Show" button and set appropriate indentation
policy and tab size. I think there is no need for a special formatter.
AFAIK, for XML sources Eclipse uses Ant editor by default, which also
uses tabs for indentation. It is possible to configure it to use
spaces, just go to "Window->Preferences->Ant->Editor->Formatter" page
and uncheck box "Use tab character insted of spaces".
The problem might be that the new formatter settings will be applied
only to the newly typed text. To apply it to existing sources one need
to reformat text using "Format" or "Correct indentation" commands in
editor view.
Thanks.
Ivan Popov
Intel Middleware Products Division
-------------
On 4/19/06, Geir Magnusson Jr <ge...@pobox.com> wrote:
> What does a "formatter profile" do? (I tend to use IDEA more than
> Eclipse - comes from being a Mac user for so many years, where Eclipse
> was utterly unusable until recently...) I assume the same-ish as a code
> style in IDEA?
>
> In IDEA, by default "use tabs" is unchecked in the global code style of
> the project code style with a tab size of 4. (IOW, tab key turns into 4
> chars...)
>
> geir
>
>
> Nathan Beyer wrote:
> > For those who use Eclipse, this is fairly trivial to do with the Java
> > editor. I've created a Formatter Profile (and tried to attach it), that can
> > be imported and should setup this style of formatting.
> >
> > If you have the Web Tools, a similar format can be created for XML files as
> > well.
> >
> > -Nathan
> >
> >> -----Original Message-----
> >> From: Geir Magnusson Jr [mailto:geir@pobox.com]
> >> Sent: Tuesday, April 18, 2006 7:01 AM
> >> To: harmony-dev@incubator.apache.org
> >> Subject: Re: svn commit: r394890 - in
> >> /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/
> >> archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/
> >> crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
> >>
> >>
> >>
> >> Richard Liang wrote:
> >>> Geir Magnusson Jr wrote:
> >>>> Wait - no tabs! no tabs! PLEASE!
> >>> +1. But are there any way to release our pain from TABs? :-)
> >> Yes - most editors will convert tabs to spaces. I suppose if we agree
> >> on a "no tabs" rule, and find files w/ tabs, lets do a conversion, and
> >> check it in w/o any other mods, with the commit log entry of "changing
> >> tabs to spaces" or such....
> >>
> >> geir
> >>
> >>
> >> ------------------------------------------------------------------------
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
RE: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Posted by Nathan Beyer <nb...@kc.rr.com>.
A formatter profile allows you to configure nearly every possible "style"
choice you can imagine for formatting Java source files; new lines (where
and how many), indentions (spaces or tabs), number of indentions per certain
keywords (switch, case, identifiers, etc), brace placement, javadoc
formatting and anything else that floats your bloat.
You can do as little as just duplicating the built-in profiles and setting
the indention policy. I just adjusted other parts of the profile because the
default conventions have some weird treatment of switch blocks, at least
weird to me.
The profile is what's used when you format source code or use the correct
indention features, which just formats the indentions of the source
(converts tabs to spaces, etc).
-Nathan
> -----Original Message-----
> From: Geir Magnusson Jr [mailto:geir@pobox.com]
> Sent: Wednesday, April 19, 2006 5:39 AM
> To: harmony-dev@incubator.apache.org
> Subject: Re: svn commit: r394890 - in
> /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/
> archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/
> crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
>
> What does a "formatter profile" do? (I tend to use IDEA more than
> Eclipse - comes from being a Mac user for so many years, where Eclipse
> was utterly unusable until recently...) I assume the same-ish as a code
> style in IDEA?
>
> In IDEA, by default "use tabs" is unchecked in the global code style of
> the project code style with a tab size of 4. (IOW, tab key turns into 4
> chars...)
>
> geir
>
>
> Nathan Beyer wrote:
> > For those who use Eclipse, this is fairly trivial to do with the Java
> > editor. I've created a Formatter Profile (and tried to attach it), that
> can
> > be imported and should setup this style of formatting.
> >
> > If you have the Web Tools, a similar format can be created for XML files
> as
> > well.
> >
> > -Nathan
> >
> >> -----Original Message-----
> >> From: Geir Magnusson Jr [mailto:geir@pobox.com]
> >> Sent: Tuesday, April 18, 2006 7:01 AM
> >> To: harmony-dev@incubator.apache.org
> >> Subject: Re: svn commit: r394890 - in
> >> /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/
> >> archive/make/common/ auth/make/common/ awt/make/common/
> beans/make/common/
> >> crypto/make/common/ jndi/make/common/ logging/make/common/
> luni/make/commo
> >>
> >>
> >>
> >> Richard Liang wrote:
> >>> Geir Magnusson Jr wrote:
> >>>> Wait - no tabs! no tabs! PLEASE!
> >>> +1. But are there any way to release our pain from TABs? :-)
> >> Yes - most editors will convert tabs to spaces. I suppose if we agree
> >> on a "no tabs" rule, and find files w/ tabs, lets do a conversion, and
> >> check it in w/o any other mods, with the commit log entry of "changing
> >> tabs to spaces" or such....
> >>
> >> geir
> >>
> >>
> >> -----------------------------------------------------------------------
> -
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules:
applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/
beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/
luni/make/commo
Posted by Geir Magnusson Jr <ge...@pobox.com>.
What does a "formatter profile" do? (I tend to use IDEA more than
Eclipse - comes from being a Mac user for so many years, where Eclipse
was utterly unusable until recently...) I assume the same-ish as a code
style in IDEA?
In IDEA, by default "use tabs" is unchecked in the global code style of
the project code style with a tab size of 4. (IOW, tab key turns into 4
chars...)
geir
Nathan Beyer wrote:
> For those who use Eclipse, this is fairly trivial to do with the Java
> editor. I've created a Formatter Profile (and tried to attach it), that can
> be imported and should setup this style of formatting.
>
> If you have the Web Tools, a similar format can be created for XML files as
> well.
>
> -Nathan
>
>> -----Original Message-----
>> From: Geir Magnusson Jr [mailto:geir@pobox.com]
>> Sent: Tuesday, April 18, 2006 7:01 AM
>> To: harmony-dev@incubator.apache.org
>> Subject: Re: svn commit: r394890 - in
>> /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/
>> archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/
>> crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
>>
>>
>>
>> Richard Liang wrote:
>>> Geir Magnusson Jr wrote:
>>>> Wait - no tabs! no tabs! PLEASE!
>>> +1. But are there any way to release our pain from TABs? :-)
>> Yes - most editors will convert tabs to spaces. I suppose if we agree
>> on a "no tabs" rule, and find files w/ tabs, lets do a conversion, and
>> check it in w/o any other mods, with the commit log entry of "changing
>> tabs to spaces" or such....
>>
>> geir
>>
>>
>> ------------------------------------------------------------------------
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
RE: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Posted by Nathan Beyer <nb...@kc.rr.com>.
For those who use Eclipse, this is fairly trivial to do with the Java
editor. I've created a Formatter Profile (and tried to attach it), that can
be imported and should setup this style of formatting.
If you have the Web Tools, a similar format can be created for XML files as
well.
-Nathan
> -----Original Message-----
> From: Geir Magnusson Jr [mailto:geir@pobox.com]
> Sent: Tuesday, April 18, 2006 7:01 AM
> To: harmony-dev@incubator.apache.org
> Subject: Re: svn commit: r394890 - in
> /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/
> archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/
> crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
>
>
>
> Richard Liang wrote:
> > Geir Magnusson Jr wrote:
> >> Wait - no tabs! no tabs! PLEASE!
>
> > +1. But are there any way to release our pain from TABs? :-)
>
> Yes - most editors will convert tabs to spaces. I suppose if we agree
> on a "no tabs" rule, and find files w/ tabs, lets do a conversion, and
> check it in w/o any other mods, with the commit log entry of "changing
> tabs to spaces" or such....
>
> geir
>
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules:
applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/
beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/
luni/make/commo
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Richard Liang wrote:
> Geir Magnusson Jr wrote:
>> Wait - no tabs! no tabs! PLEASE!
> +1. But are there any way to release our pain from TABs? :-)
Yes - most editors will convert tabs to spaces. I suppose if we agree
on a "no tabs" rule, and find files w/ tabs, lets do a conversion, and
check it in w/o any other mods, with the commit log entry of "changing
tabs to spaces" or such....
geir
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules:
applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/
beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/
luni/make/commo
Posted by Richard Liang <ri...@gmail.com>.
Geir Magnusson Jr wrote:
> Wait - no tabs! no tabs! PLEASE!
>
> You can have your 1,743 character test case names if you want, but NO
> TABS! :)
>
> geir
>
> Mark Hindess wrote:
>> Stepan,
>>
>> Just curious what you are fixing here? Changing 8 spaces to tabs?
>> Why does this matter? Shouldn't tabs (at the beginning of a line)
>> always be equivalent to 8 spaces?
>>
>> Incidentally, I think 8 character indentations are excessive. Quite a
>> few of the ant files use 4 character indentations which I find much
>> easier to read. Ditto for java code. Perhaps we could agree which to
>> use?
>>
>> Regards,
>> -Mark - wondering if he might regret asking this
>>
>> On 4/18/06, smishura@apache.org <sm...@apache.org> wrote:
>>> Author: smishura
>>> Date: Tue Apr 18 02:38:29 2006
>>> New Revision: 394890
>>>
>>> URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
>>> Log:
>>> Correcting indentation
>>>
>>> Modified:
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
>>>
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
>>>
>>>
>>> Modified:
>>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>>
>>> URL:
>>> http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>> (original)
>>> +++
>>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>> Tue Apr 18 02:38:29 2006
>>> @@ -68,12 +68,12 @@
>>>
>>>
>>> <target name="run.tests">
>>> -
>>> - <mkdir dir="${hy.tests.reports}" />
>>> +
>>> + <mkdir dir="${hy.tests.reports}" />
>>>
>>> <property name="test.jre.home"
>>> value="${hy.target}/jre" />
>>>
>>> - <junit fork="yes"
>>> + <junit fork="yes"
>>> forkmode="once"
>>> printsummary="withOutAndErr"
>>> errorproperty="test.errors"
>>>
>>> [ SNIP ]
>>
>> --
>> Mark Hindess <ma...@googlemail.com>
>> IBM Java Technology Centre, UK.
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
+1. But are there any way to release our pain from TABs? :-)
--
Richard Liang
China Software Development Lab, IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules:
applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/
beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/
luni/make/commo
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Wait - no tabs! no tabs! PLEASE!
You can have your 1,743 character test case names if you want, but NO
TABS! :)
geir
Mark Hindess wrote:
> Stepan,
>
> Just curious what you are fixing here? Changing 8 spaces to tabs?
> Why does this matter? Shouldn't tabs (at the beginning of a line)
> always be equivalent to 8 spaces?
>
> Incidentally, I think 8 character indentations are excessive. Quite a
> few of the ant files use 4 character indentations which I find much
> easier to read. Ditto for java code. Perhaps we could agree which to
> use?
>
> Regards,
> -Mark - wondering if he might regret asking this
>
> On 4/18/06, smishura@apache.org <sm...@apache.org> wrote:
>> Author: smishura
>> Date: Tue Apr 18 02:38:29 2006
>> New Revision: 394890
>>
>> URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
>> Log:
>> Correcting indentation
>>
>> Modified:
>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
>> incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
>>
>> Modified: incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>> URL: http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
>> ==============================================================================
>> --- incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml (original)
>> +++ incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml Tue Apr 18 02:38:29 2006
>> @@ -68,12 +68,12 @@
>>
>>
>> <target name="run.tests">
>> -
>> - <mkdir dir="${hy.tests.reports}" />
>> +
>> + <mkdir dir="${hy.tests.reports}" />
>>
>> <property name="test.jre.home" value="${hy.target}/jre" />
>>
>> - <junit fork="yes"
>> + <junit fork="yes"
>> forkmode="once"
>> printsummary="withOutAndErr"
>> errorproperty="test.errors"
>>
>> [ SNIP ]
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules:
applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/
beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/
luni/make/commo
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Mark Hindess wrote:
> Stepan,
>
> Sorry. I didn't mean to blame you. I did realise that you were just
> putting it back to the "initial" style.
>
> Since you asked (well almost ;-) I'm in favour of 4 space indent since
> this is quite common in the java code. Unlike Geir I don't mind if
> tabs are used but they should always be treated as being equivalent to
> 8 spaces. Though I'd might change my mind if I understood the
> motivation behind Geir's aversion to tabs.
They just lead to pain.
Spaces makes it format the same everywhere, and people don't mistakenly
use tabs to format, resulting in distortion for other people. You can
train any reasonably modern IDE/editor to convert tabs to spaces, so you
can use the tab key (set it at 4 spaces). As a developer, you don't
know the difference - hit the tab key to your hearts content - and we
then all live in harmony :)
The assumption is we agree on a format style (4 spaces for indent)....
geir
>
> Regards,
> Mark.
>
> On 4/18/06, Stepan Mishura <st...@gmail.com> wrote:
>> Mark,
>>
>> The update only adjusts build files to *initial* style (that is tabs-style).
>>
>> IMHO really doesn't matter how many spaces in one tab if you follow one
>> style in a file and don't mix tabs with spaces. Also I like
>> tab-style because I have opportunity to choose a number of spaces that more
>> suitable for my eyes. If everybody will agree to use only space-style then
>> OK - I'll fix tabs.
>>
>> Thanks,
>> Stepan.
>>
>>
>> On 4/18/06, Mark Hindess wrote:
>>> For many people however tabs are equivalent to 8 spaces so if what we
>>> really intend is 4 spaces then perhaps we should make them spaces not
>>> tabs?
>>>
>>> Otherwise we will be forever fixing identations because of editor
>>> differences.
>>>
>>> -Mark.
>>>
>>> On 4/18/06, Stepan Mishura <st...@gmail.com> wrote:
>>>> On 4/18/06, Mark Hindess wrote:
>>>>> Stepan,
>>>>>
>>>>> Just curious what you are fixing here? Changing 8 spaces to tabs?
>>>>> Why does this matter? Shouldn't tabs (at the beginning of a line)
>>>>> always be equivalent to 8 spaces?
>>>>
>>>> Mark,
>>>>
>>>> I'd prefer to have all build files follow one style - I don't like
>>> mixing
>>>> tabs and spaces even they looks the same. For this particular case -
>>> build
>>>> files were initially created using tabs and I'd prefer to keep this
>>> style.
>>>> Also for me tab is not equivalent to 8 spaces - Eclipse sets tab
>>> equivalent
>>>> to 4 spaces and I'm not going to change it because I like it :-)
>>>>
>>>> Thanks,
>>>> Stepan.
>>>>
>>>> Incidentally, I think 8 character indentations are excessive. Quite a
>>>>> few of the ant files use 4 character indentations which I find much
>>>>> easier to read. Ditto for java code. Perhaps we could agree which to
>>>>> use?
>>>>>
>>>>> Regards,
>>>>> -Mark - wondering if he might regret asking this
>>>>>
>>>>> On 4/18/06, smishura@apache.org <sm...@apache.org> wrote:
>>>>>> Author: smishura
>>>>>> Date: Tue Apr 18 02:38:29 2006
>>>>>> New Revision: 394890
>>>>>>
>>>>>> URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
>>>>>> Log:
>>>>>> Correcting indentation
>>>>>>
>>>>>> Modified:
>>>>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
>>> incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
>>>>>> Modified:
>>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>>>>> URL:
>>> http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
>>> ==============================================================================
>>>>>> ---
>>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>>>> (original)
>>>>>> +++
>>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>>>> Tue Apr 18 02:38:29 2006
>>>>>> @@ -68,12 +68,12 @@
>>>>>>
>>>>>>
>>>>>> <target name="run.tests">
>>>>>> -
>>>>>> - <mkdir dir="${hy.tests.reports}" />
>>>>>> +
>>>>>> + <mkdir dir="${hy.tests.reports}" />
>>>>>>
>>>>>> <property name="test.jre.home" value="${hy.target
>>> }/jre"
>>>>> />
>>>>>> - <junit fork="yes"
>>>>>> + <junit fork="yes"
>>>>>> forkmode="once"
>>>>>> printsummary="withOutAndErr"
>>>>>> errorproperty="test.errors"
>>>>>>
>>>>>> [ SNIP ]
>>>>> --
>>>>> Mark Hindess <ma...@googlemail.com>
>>>>> IBM Java Technology Centre, UK.
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>
>>>>>
>>>>
>>>> --
>>>> -----------------------------------------------------------
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>
>>>> Thanks,
>>>> Stepan Mishura
>>>> Intel Middleware Products Division
>>>>
>>>>
>>>
>>> --
>>> Mark Hindess <ma...@googlemail.com>
>>> IBM Java Technology Centre, UK.
>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>>
>> --
>> -----------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>> Thanks,
>> Stepan Mishura
>> Intel Middleware Products Division
>>
>>
>
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Posted by Stepan Mishura <st...@gmail.com>.
On 4/18/06, Mark Hindess wrote:
>
> Stepan,
>
> Sorry. I didn't mean to blame you. I did realise that you were just
> putting it back to the "initial" style.
Mark, I also expected that you didn't want to blame me :-) As far as English
is not my native language I used to read messages in a way like my good
friend points out to my mistakes (except if a message is not obviously
rude).
> Since you asked (well almost ;-) I'm in favour of 4 space indent since
> this is quite common in the java code. Unlike Geir I don't mind if
> tabs are used but they should always be treated as being equivalent to
> 8 spaces. Though I'd might change my mind if I understood the
> motivation behind Geir's aversion to tabs.
OK. If there will be no objections I'm going to replace tabs with 4 space
indent in build files.
Thanks,
Stepan.
Regards,
> Mark.
>
> On 4/18/06, Stepan Mishura <st...@gmail.com> wrote:
> > Mark,
> >
> > The update only adjusts build files to *initial* style (that is
> tabs-style).
> >
> > IMHO really doesn't matter how many spaces in one tab if you follow one
> > style in a file and don't mix tabs with spaces. Also I like
> > tab-style because I have opportunity to choose a number of spaces that
> more
> > suitable for my eyes. If everybody will agree to use only space-style
> then
> > OK - I'll fix tabs.
> >
> > Thanks,
> > Stepan.
> >
> >
> > On 4/18/06, Mark Hindess wrote:
> > >
> > > For many people however tabs are equivalent to 8 spaces so if what we
> > > really intend is 4 spaces then perhaps we should make them spaces not
> > > tabs?
> > >
> > > Otherwise we will be forever fixing identations because of editor
> > > differences.
> > >
> > > -Mark.
> > >
> > > On 4/18/06, Stepan Mishura <st...@gmail.com> wrote:
> > > > On 4/18/06, Mark Hindess wrote:
> > > > >
> > > > > Stepan,
> > > > >
> > > > > Just curious what you are fixing here? Changing 8 spaces to tabs?
> > > > > Why does this matter? Shouldn't tabs (at the beginning of a line)
> > > > > always be equivalent to 8 spaces?
> > > >
> > > >
> > > > Mark,
> > > >
> > > > I'd prefer to have all build files follow one style - I don't like
> > > mixing
> > > > tabs and spaces even they looks the same. For this particular case -
> > > build
> > > > files were initially created using tabs and I'd prefer to keep this
> > > style.
> > > > Also for me tab is not equivalent to 8 spaces - Eclipse sets tab
> > > equivalent
> > > > to 4 spaces and I'm not going to change it because I like it :-)
> > > >
> > > > Thanks,
> > > > Stepan.
> > > >
> > > > Incidentally, I think 8 character indentations are excessive. Quite
> a
> > > > > few of the ant files use 4 character indentations which I find
> much
> > > > > easier to read. Ditto for java code. Perhaps we could agree
> which to
> > > > > use?
> > > > >
> > > > > Regards,
> > > > > -Mark - wondering if he might regret asking this
> > > > >
> > > > > On 4/18/06, smishura@apache.org <sm...@apache.org> wrote:
> > > > > > Author: smishura
> > > > > > Date: Tue Apr 18 02:38:29 2006
> > > > > > New Revision: 394890
> > > > > >
> > > > > > URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
> > > > > > Log:
> > > > > > Correcting indentation
> > > > > >
> > > > > > Modified:
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
> > > > > >
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
> > > > > >
> > > > > > Modified:
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > > > URL:
> > > > >
> > >
> http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
> > > > > >
> > > > >
> > >
> ==============================================================================
> > > > > > ---
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > > (original)
> > > > > > +++
> > > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > > Tue Apr 18 02:38:29 2006
> > > > > > @@ -68,12 +68,12 @@
> > > > > >
> > > > > >
> > > > > > <target name="run.tests">
> > > > > > -
> > > > > > - <mkdir dir="${hy.tests.reports}" />
> > > > > > +
> > > > > > + <mkdir dir="${hy.tests.reports}" />
> > > > > >
> > > > > > <property name="test.jre.home" value="${
> hy.target
> > > }/jre"
> > > > > />
> > > > > >
> > > > > > - <junit fork="yes"
> > > > > > + <junit fork="yes"
> > > > > > forkmode="once"
> > > > > > printsummary="withOutAndErr"
> > > > > > errorproperty="test.errors"
> > > > > >
> > > > > > [ SNIP ]
> > > > >
> > > > > --
> > > > > Mark Hindess <ma...@googlemail.com>
> > > > > IBM Java Technology Centre, UK.
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > To unsubscribe, e-mail:
> harmony-dev-unsubscribe@incubator.apache.org
> > > > > For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > -----------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> > > >
> > > > Thanks,
> > > > Stepan Mishura
> > > > Intel Middleware Products Division
> > > >
> > > >
> > >
> > >
> > > --
> > > Mark Hindess <ma...@googlemail.com>
> > > IBM Java Technology Centre, UK.
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > -----------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> > Thanks,
> > Stepan Mishura
> > Intel Middleware Products Division
> >
> >
>
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
-----------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Thanks,
Stepan Mishura
Intel Middleware Products Division
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Posted by Mark Hindess <ma...@googlemail.com>.
Stepan,
Sorry. I didn't mean to blame you. I did realise that you were just
putting it back to the "initial" style.
Since you asked (well almost ;-) I'm in favour of 4 space indent since
this is quite common in the java code. Unlike Geir I don't mind if
tabs are used but they should always be treated as being equivalent to
8 spaces. Though I'd might change my mind if I understood the
motivation behind Geir's aversion to tabs.
Regards,
Mark.
On 4/18/06, Stepan Mishura <st...@gmail.com> wrote:
> Mark,
>
> The update only adjusts build files to *initial* style (that is tabs-style).
>
> IMHO really doesn't matter how many spaces in one tab if you follow one
> style in a file and don't mix tabs with spaces. Also I like
> tab-style because I have opportunity to choose a number of spaces that more
> suitable for my eyes. If everybody will agree to use only space-style then
> OK - I'll fix tabs.
>
> Thanks,
> Stepan.
>
>
> On 4/18/06, Mark Hindess wrote:
> >
> > For many people however tabs are equivalent to 8 spaces so if what we
> > really intend is 4 spaces then perhaps we should make them spaces not
> > tabs?
> >
> > Otherwise we will be forever fixing identations because of editor
> > differences.
> >
> > -Mark.
> >
> > On 4/18/06, Stepan Mishura <st...@gmail.com> wrote:
> > > On 4/18/06, Mark Hindess wrote:
> > > >
> > > > Stepan,
> > > >
> > > > Just curious what you are fixing here? Changing 8 spaces to tabs?
> > > > Why does this matter? Shouldn't tabs (at the beginning of a line)
> > > > always be equivalent to 8 spaces?
> > >
> > >
> > > Mark,
> > >
> > > I'd prefer to have all build files follow one style - I don't like
> > mixing
> > > tabs and spaces even they looks the same. For this particular case -
> > build
> > > files were initially created using tabs and I'd prefer to keep this
> > style.
> > > Also for me tab is not equivalent to 8 spaces - Eclipse sets tab
> > equivalent
> > > to 4 spaces and I'm not going to change it because I like it :-)
> > >
> > > Thanks,
> > > Stepan.
> > >
> > > Incidentally, I think 8 character indentations are excessive. Quite a
> > > > few of the ant files use 4 character indentations which I find much
> > > > easier to read. Ditto for java code. Perhaps we could agree which to
> > > > use?
> > > >
> > > > Regards,
> > > > -Mark - wondering if he might regret asking this
> > > >
> > > > On 4/18/06, smishura@apache.org <sm...@apache.org> wrote:
> > > > > Author: smishura
> > > > > Date: Tue Apr 18 02:38:29 2006
> > > > > New Revision: 394890
> > > > >
> > > > > URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
> > > > > Log:
> > > > > Correcting indentation
> > > > >
> > > > > Modified:
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
> > > > >
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
> > > > >
> > > > > Modified:
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > > URL:
> > > >
> > http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
> > > > >
> > > >
> > ==============================================================================
> > > > > ---
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > (original)
> > > > > +++
> > > >
> > incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > Tue Apr 18 02:38:29 2006
> > > > > @@ -68,12 +68,12 @@
> > > > >
> > > > >
> > > > > <target name="run.tests">
> > > > > -
> > > > > - <mkdir dir="${hy.tests.reports}" />
> > > > > +
> > > > > + <mkdir dir="${hy.tests.reports}" />
> > > > >
> > > > > <property name="test.jre.home" value="${hy.target
> > }/jre"
> > > > />
> > > > >
> > > > > - <junit fork="yes"
> > > > > + <junit fork="yes"
> > > > > forkmode="once"
> > > > > printsummary="withOutAndErr"
> > > > > errorproperty="test.errors"
> > > > >
> > > > > [ SNIP ]
> > > >
> > > > --
> > > > Mark Hindess <ma...@googlemail.com>
> > > > IBM Java Technology Centre, UK.
> > > >
> > > > ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > >
> > > >
> > >
> > >
> > > --
> > > -----------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > > Thanks,
> > > Stepan Mishura
> > > Intel Middleware Products Division
> > >
> > >
> >
> >
> > --
> > Mark Hindess <ma...@googlemail.com>
> > IBM Java Technology Centre, UK.
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> -----------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
> Thanks,
> Stepan Mishura
> Intel Middleware Products Division
>
>
--
Mark Hindess <ma...@googlemail.com>
IBM Java Technology Centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Posted by Anton Avtamonov <an...@gmail.com>.
On 4/18/06, Stepan Mishura <st...@gmail.com> wrote:
> Mark,
>
> The update only adjusts build files to *initial* style (that is tabs-style).
>
> IMHO really doesn't matter how many spaces in one tab if you follow one
> style in a file and don't mix tabs with spaces. Also I like
> tab-style because I have opportunity to choose a number of spaces that more
> suitable for my eyes. If everybody will agree to use only space-style then
> OK - I'll fix tabs.
Stepan,
If it was a question I also vote for space-style. It guarantees same
look in all editors. I used to 4-spaces indentation.
--
Anton Avtamonov,
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Posted by Stepan Mishura <st...@gmail.com>.
Mark,
The update only adjusts build files to *initial* style (that is tabs-style).
IMHO really doesn't matter how many spaces in one tab if you follow one
style in a file and don't mix tabs with spaces. Also I like
tab-style because I have opportunity to choose a number of spaces that more
suitable for my eyes. If everybody will agree to use only space-style then
OK - I'll fix tabs.
Thanks,
Stepan.
On 4/18/06, Mark Hindess wrote:
>
> For many people however tabs are equivalent to 8 spaces so if what we
> really intend is 4 spaces then perhaps we should make them spaces not
> tabs?
>
> Otherwise we will be forever fixing identations because of editor
> differences.
>
> -Mark.
>
> On 4/18/06, Stepan Mishura <st...@gmail.com> wrote:
> > On 4/18/06, Mark Hindess wrote:
> > >
> > > Stepan,
> > >
> > > Just curious what you are fixing here? Changing 8 spaces to tabs?
> > > Why does this matter? Shouldn't tabs (at the beginning of a line)
> > > always be equivalent to 8 spaces?
> >
> >
> > Mark,
> >
> > I'd prefer to have all build files follow one style - I don't like
> mixing
> > tabs and spaces even they looks the same. For this particular case -
> build
> > files were initially created using tabs and I'd prefer to keep this
> style.
> > Also for me tab is not equivalent to 8 spaces - Eclipse sets tab
> equivalent
> > to 4 spaces and I'm not going to change it because I like it :-)
> >
> > Thanks,
> > Stepan.
> >
> > Incidentally, I think 8 character indentations are excessive. Quite a
> > > few of the ant files use 4 character indentations which I find much
> > > easier to read. Ditto for java code. Perhaps we could agree which to
> > > use?
> > >
> > > Regards,
> > > -Mark - wondering if he might regret asking this
> > >
> > > On 4/18/06, smishura@apache.org <sm...@apache.org> wrote:
> > > > Author: smishura
> > > > Date: Tue Apr 18 02:38:29 2006
> > > > New Revision: 394890
> > > >
> > > > URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
> > > > Log:
> > > > Correcting indentation
> > > >
> > > > Modified:
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
> > > >
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
> > > >
> > > > Modified:
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > > URL:
> > >
> http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
> > > >
> > >
> ==============================================================================
> > > > ---
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > (original)
> > > > +++
> > >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > Tue Apr 18 02:38:29 2006
> > > > @@ -68,12 +68,12 @@
> > > >
> > > >
> > > > <target name="run.tests">
> > > > -
> > > > - <mkdir dir="${hy.tests.reports}" />
> > > > +
> > > > + <mkdir dir="${hy.tests.reports}" />
> > > >
> > > > <property name="test.jre.home" value="${hy.target
> }/jre"
> > > />
> > > >
> > > > - <junit fork="yes"
> > > > + <junit fork="yes"
> > > > forkmode="once"
> > > > printsummary="withOutAndErr"
> > > > errorproperty="test.errors"
> > > >
> > > > [ SNIP ]
> > >
> > > --
> > > Mark Hindess <ma...@googlemail.com>
> > > IBM Java Technology Centre, UK.
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > -----------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> > Thanks,
> > Stepan Mishura
> > Intel Middleware Products Division
> >
> >
>
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
-----------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Thanks,
Stepan Mishura
Intel Middleware Products Division
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules:
applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/
beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/
luni/make/commo
Posted by Paulex Yang <pa...@gmail.com>.
Mark Hindess wrote:
> For many people however tabs are equivalent to 8 spaces so if what we
> really intend is 4 spaces then perhaps we should make them spaces not
> tabs?
>
I agree that it is good practice to always use spaces instead of tabs.
And AFAIK many editors(say, Eclipse, VI) can set this preference so that
this requirement should not introduce too much effort to developers.
> Otherwise we will be forever fixing identations because of editor differences.
>
> -Mark.
>
> On 4/18/06, Stepan Mishura <st...@gmail.com> wrote:
>
>> On 4/18/06, Mark Hindess wrote:
>>
>>> Stepan,
>>>
>>> Just curious what you are fixing here? Changing 8 spaces to tabs?
>>> Why does this matter? Shouldn't tabs (at the beginning of a line)
>>> always be equivalent to 8 spaces?
>>>
>> Mark,
>>
>> I'd prefer to have all build files follow one style - I don't like mixing
>> tabs and spaces even they looks the same. For this particular case - build
>> files were initially created using tabs and I'd prefer to keep this style.
>> Also for me tab is not equivalent to 8 spaces - Eclipse sets tab equivalent
>> to 4 spaces and I'm not going to change it because I like it :-)
>>
>> Thanks,
>> Stepan.
>>
>> Incidentally, I think 8 character indentations are excessive. Quite a
>>
>>> few of the ant files use 4 character indentations which I find much
>>> easier to read. Ditto for java code. Perhaps we could agree which to
>>> use?
>>>
>>> Regards,
>>> -Mark - wondering if he might regret asking this
>>>
>>> On 4/18/06, smishura@apache.org <sm...@apache.org> wrote:
>>>
>>>> Author: smishura
>>>> Date: Tue Apr 18 02:38:29 2006
>>>> New Revision: 394890
>>>>
>>>> URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
>>>> Log:
>>>> Correcting indentation
>>>>
>>>> Modified:
>>>>
>>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
>>>
>>>> Modified:
>>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>>
>>>> URL:
>>>>
>>> http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
>>>
>>> ==============================================================================
>>>
>>>> ---
>>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>> (original)
>>>
>>>> +++
>>>>
>>> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
>>> Tue Apr 18 02:38:29 2006
>>>
>>>> @@ -68,12 +68,12 @@
>>>>
>>>>
>>>> <target name="run.tests">
>>>> -
>>>> - <mkdir dir="${hy.tests.reports}" />
>>>> +
>>>> + <mkdir dir="${hy.tests.reports}" />
>>>>
>>>> <property name="test.jre.home" value="${hy.target}/jre"
>>>>
>>> />
>>>
>>>> - <junit fork="yes"
>>>> + <junit fork="yes"
>>>> forkmode="once"
>>>> printsummary="withOutAndErr"
>>>> errorproperty="test.errors"
>>>>
>>>> [ SNIP ]
>>>>
>>> --
>>> Mark Hindess <ma...@googlemail.com>
>>> IBM Java Technology Centre, UK.
>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>>>
>> --
>> -----------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>> Thanks,
>> Stepan Mishura
>> Intel Middleware Products Division
>>
>>
>>
>
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
>
--
Paulex Yang
China Software Development Lab
IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Posted by Mark Hindess <ma...@googlemail.com>.
For many people however tabs are equivalent to 8 spaces so if what we
really intend is 4 spaces then perhaps we should make them spaces not
tabs?
Otherwise we will be forever fixing identations because of editor differences.
-Mark.
On 4/18/06, Stepan Mishura <st...@gmail.com> wrote:
> On 4/18/06, Mark Hindess wrote:
> >
> > Stepan,
> >
> > Just curious what you are fixing here? Changing 8 spaces to tabs?
> > Why does this matter? Shouldn't tabs (at the beginning of a line)
> > always be equivalent to 8 spaces?
>
>
> Mark,
>
> I'd prefer to have all build files follow one style - I don't like mixing
> tabs and spaces even they looks the same. For this particular case - build
> files were initially created using tabs and I'd prefer to keep this style.
> Also for me tab is not equivalent to 8 spaces - Eclipse sets tab equivalent
> to 4 spaces and I'm not going to change it because I like it :-)
>
> Thanks,
> Stepan.
>
> Incidentally, I think 8 character indentations are excessive. Quite a
> > few of the ant files use 4 character indentations which I find much
> > easier to read. Ditto for java code. Perhaps we could agree which to
> > use?
> >
> > Regards,
> > -Mark - wondering if he might regret asking this
> >
> > On 4/18/06, smishura@apache.org <sm...@apache.org> wrote:
> > > Author: smishura
> > > Date: Tue Apr 18 02:38:29 2006
> > > New Revision: 394890
> > >
> > > URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
> > > Log:
> > > Correcting indentation
> > >
> > > Modified:
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
> > >
> > incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
> > >
> > > Modified:
> > incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > > URL:
> > http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
> > >
> > ==============================================================================
> > > ---
> > incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > (original)
> > > +++
> > incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > Tue Apr 18 02:38:29 2006
> > > @@ -68,12 +68,12 @@
> > >
> > >
> > > <target name="run.tests">
> > > -
> > > - <mkdir dir="${hy.tests.reports}" />
> > > +
> > > + <mkdir dir="${hy.tests.reports}" />
> > >
> > > <property name="test.jre.home" value="${hy.target}/jre"
> > />
> > >
> > > - <junit fork="yes"
> > > + <junit fork="yes"
> > > forkmode="once"
> > > printsummary="withOutAndErr"
> > > errorproperty="test.errors"
> > >
> > > [ SNIP ]
> >
> > --
> > Mark Hindess <ma...@googlemail.com>
> > IBM Java Technology Centre, UK.
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> -----------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
> Thanks,
> Stepan Mishura
> Intel Middleware Products Division
>
>
--
Mark Hindess <ma...@googlemail.com>
IBM Java Technology Centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r394890 - in /incubator/harmony/enhanced/classlib/trunk/modules: applet/make/common/ archive/make/common/ auth/make/common/ awt/make/common/ beans/make/common/ crypto/make/common/ jndi/make/common/ logging/make/common/ luni/make/commo
Posted by Stepan Mishura <st...@gmail.com>.
On 4/18/06, Mark Hindess wrote:
>
> Stepan,
>
> Just curious what you are fixing here? Changing 8 spaces to tabs?
> Why does this matter? Shouldn't tabs (at the beginning of a line)
> always be equivalent to 8 spaces?
Mark,
I'd prefer to have all build files follow one style - I don't like mixing
tabs and spaces even they looks the same. For this particular case - build
files were initially created using tabs and I'd prefer to keep this style.
Also for me tab is not equivalent to 8 spaces - Eclipse sets tab equivalent
to 4 spaces and I'm not going to change it because I like it :-)
Thanks,
Stepan.
Incidentally, I think 8 character indentations are excessive. Quite a
> few of the ant files use 4 character indentations which I find much
> easier to read. Ditto for java code. Perhaps we could agree which to
> use?
>
> Regards,
> -Mark - wondering if he might regret asking this
>
> On 4/18/06, smishura@apache.org <sm...@apache.org> wrote:
> > Author: smishura
> > Date: Tue Apr 18 02:38:29 2006
> > New Revision: 394890
> >
> > URL: http://svn.apache.org/viewcvs?rev=394890&view=rev
> > Log:
> > Correcting indentation
> >
> > Modified:
> >
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/archive/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/auth/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/awt/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/beans/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/crypto/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/jndi/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/logging/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/luni/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/math/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/nio/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/nio_char/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/prefs/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/regex/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/rmi/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/security/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/sql/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/text/make/common/build.xml
> >
> incubator/harmony/enhanced/classlib/trunk/modules/x-net/make/common/build.xml
> >
> > Modified:
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> > URL:
> http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml?rev=394890&r1=394889&r2=394890&view=diff
> >
> ==============================================================================
> > ---
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> (original)
> > +++
> incubator/harmony/enhanced/classlib/trunk/modules/applet/make/common/build.xml
> Tue Apr 18 02:38:29 2006
> > @@ -68,12 +68,12 @@
> >
> >
> > <target name="run.tests">
> > -
> > - <mkdir dir="${hy.tests.reports}" />
> > +
> > + <mkdir dir="${hy.tests.reports}" />
> >
> > <property name="test.jre.home" value="${hy.target}/jre"
> />
> >
> > - <junit fork="yes"
> > + <junit fork="yes"
> > forkmode="once"
> > printsummary="withOutAndErr"
> > errorproperty="test.errors"
> >
> > [ SNIP ]
>
> --
> Mark Hindess <ma...@googlemail.com>
> IBM Java Technology Centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
-----------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Thanks,
Stepan Mishura
Intel Middleware Products Division