You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by yl...@apache.org on 2019/09/16 11:46:27 UTC

svn commit: r1866998 - /httpd/httpd/trunk/modules/http/http_filters.c

Author: ylavic
Date: Mon Sep 16 11:46:27 2019
New Revision: 1866998

URL: http://svn.apache.org/viewvc?rev=1866998&view=rev
Log:
ap_http_header_filter: avoid double encoding of output headers in traces.

When output headers are logged (TRACE4) in send_all_header_fields(), we don't
need to explicitely ap_escape_logitem() them since ap_log_rerror() takes care
of log files escaping already.

Otherwise, characters like '"' are unncesseralily encoded, and '\\' is doubly
encoded (including for controls).

Modified:
    httpd/httpd/trunk/modules/http/http_filters.c

Modified: httpd/httpd/trunk/modules/http/http_filters.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_filters.c?rev=1866998&r1=1866997&r2=1866998&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/http/http_filters.c (original)
+++ httpd/httpd/trunk/modules/http/http_filters.c Mon Sep 16 11:46:27 2019
@@ -898,8 +898,7 @@ static apr_status_t send_all_header_fiel
         t_elt = (const apr_table_entry_t *)(elts->elts);
         do {
             ap_log_rerror(APLOG_MARK, APLOG_TRACE4, 0, r, "  %s: %s",
-                          ap_escape_logitem(r->pool, t_elt->key),
-                          ap_escape_logitem(r->pool, t_elt->val));
+                          t_elt->key, t_elt->val);
             t_elt++;
         } while (t_elt < t_end);
     }