You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/18 09:11:32 UTC

[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #4272: reimplement `eliminate_outer_join`

jackwener commented on code in PR #4272:
URL: https://github.com/apache/arrow-datafusion/pull/4272#discussion_r1026185811


##########
datafusion/optimizer/src/eliminate_outer_join.rs:
##########
@@ -39,191 +38,107 @@ impl ReduceOuterJoin {
     }
 }
 
+/// Attempt to eliminate outer joins to inner joins.

Review Comment:
   You can see `fn eliminate_outer()`
   Your example, this rule can do.
   We can eliminate Full -> ROJ/LOJ/Inner



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org