You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2026/05/15 16:31:18 UTC
[PR] refactor(controller): stabilize lifecycle pipeline with Jobs [superset-kubernetes-operator]
villebro opened a new pull request, #57:
URL: https://github.com/apache/superset-kubernetes-operator/pull/57
## Summary
This PR hardens the Superset lifecycle pipeline after the single-CRD refactor by moving lifecycle task execution to deterministic parent-owned Kubernetes Jobs and tightening drain, maintenance, checksum, and status semantics.
The goal is to make clone/migrate/rotate/init execution predictable, prevent duplicate task runs, avoid unnecessary maintenance/drain cycles, and make `kubectl get/describe` accurately reflect what the operator is doing.
## Details
- Run lifecycle tasks as deterministic Jobs instead of generated bare Pods.
- Prevent duplicate migrate/init execution by reconciling against the actual Job template image instead of stale parent status.
- Include the target Superset lifecycle image in clone checksums so image changes can retrigger clone and cascade downstream.
- Drain only when a task that will actually run requires drain.
- Skip maintenance page startup on initial installs with no existing web-server workload.
- Keep maintenance scoped to web traffic: during maintenance, only web-server readiness is suppressed; workers report observed readiness.
- Add `Lifecycle` as a `kubectl get supersets` print column.
- Keep top-level `PHASE` high-level (`Initializing`, `Upgrading`, `Running`, etc.) and use `LIFECYCLE` for step-level state (`Draining`, `Migrating`,
`Restoring`, etc.).
- Add `Restoring` lifecycle phase for the post-task component rollout / maintenance switchback window.
- Update status aggregation, API docs, CRDs, architecture docs, and lifecycle guide.
- Add regression coverage for duplicate Jobs, checksum behavior, drain decisions, maintenance gating, and lifecycle/status reporting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(controller): stabilize lifecycle pipeline with Jobs [superset-kubernetes-operator]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #57:
URL: https://github.com/apache/superset-kubernetes-operator/pull/57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor(controller): stabilize lifecycle pipeline with Jobs [superset-kubernetes-operator]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #57:
URL: https://github.com/apache/superset-kubernetes-operator/pull/57#issuecomment-4461543269
## [Codecov](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.16541%` with `225 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 76.10%. Comparing base ([`5c9291e`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/5c9291e5fabd6c9d3dd17c8714ede5217b680c07?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`739dacd`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/739dacd7597efd6e34f95971a9f29756b87a7369?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [internal/controller/lifecycle\_job.go](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?src=pr&el=tree&filepath=internal%2Fcontroller%2Flifecycle_job.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwvY29udHJvbGxlci9saWZlY3ljbGVfam9iLmdv) | 59.64% | [111 Missing and 27 partials :warning: ](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [internal/controller/drain.go](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?src=pr&el=tree&filepath=internal%2Fcontroller%2Fdrain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwvY29udHJvbGxlci9kcmFpbi5nbw==) | 70.70% | [23 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [internal/controller/lifecycle.go](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?src=pr&el=tree&filepath=internal%2Fcontroller%2Flifecycle.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwvY29udHJvbGxlci9saWZlY3ljbGUuZ28=) | 47.72% | [18 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [internal/controller/maintenance.go](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?src=pr&el=tree&filepath=internal%2Fcontroller%2Fmaintenance.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwvY29udHJvbGxlci9tYWludGVuYW5jZS5nbw==) | 70.27% | [15 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [internal/controller/status.go](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?src=pr&el=tree&filepath=internal%2Fcontroller%2Fstatus.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwvY29udHJvbGxlci9zdGF0dXMuZ28=) | 92.47% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [internal/controller/superset\_controller.go](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?src=pr&el=tree&filepath=internal%2Fcontroller%2Fsuperset_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwvY29udHJvbGxlci9zdXBlcnNldF9jb250cm9sbGVyLmdv) | 25.00% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/57?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org