[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

["Rohini Palaniswamy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938496#comment-13938496 ] 

Rohini Palaniswamy commented on OOZIE-1638:
-------------------------------------------

Few minor comments:
    - Can you remove assertTrue(true); ?
    - In oozie-default.xml can you change the default value for oozie.service.LiteWorkflowStoreService.user.retry.max to 0 since that is the current behavior. Else suddenly there will be user retries with this release when it was not happening before. If default retries are needed, admins can set that in oozie-site.xml. 

[~rkanter],
     What is your thought on second comment? Should we leave the default at 3 or change it to 0. The documentation also does not talk about a default retry. 

> Action retry does not use default retry max count.
> --------------------------------------------------
>
>                 Key: OOZIE-1638
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1638
>             Project: Oozie
>          Issue Type: Bug
>          Components: action
>    Affects Versions: 4.0.0
>            Reporter: Azrael
>            Priority: Minor
>         Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, OOZIE-1638.4.patch, OOZIE-1638.patch
>
>
> the oozie-default
> {code:xml}
> <property>
>         <name>oozie.service.LiteWorkflowStoreService.user.retry.max</name>
>         <value>3</value>
>         <description>
>             Automatic retry max count for workflow action is 3 in default.
>         </description>
> </property>
> {code}
> but the action failed with error, is not retried. 
> It should retry $\{user.retry.max\} times.
> If the patch applied, some other tests in TestActionError failed because the action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.2#6252)