[GitHub] [incubator-inlong] kipshi commented on a diff in pull request #4558: [INLONG-4556][Manager] Optimize ProcessorExecutor Logic

[GitBox <gi...@apache.org>]

kipshi commented on code in PR #4558:
URL: https://github.com/apache/incubator-inlong/pull/4558#discussion_r891176553


##########
inlong-manager/manager-workflow/src/main/java/org/apache/inlong/manager/workflow/processor/ServiceTaskProcessor.java:
##########
@@ -77,24 +77,28 @@ public Class<ServiceTask> watch() {
     public void create(ServiceTask serviceTask, WorkflowContext context) {
         WorkflowTaskEntity workflowTaskEntity = saveTaskEntity(serviceTask, context);
         context.getNewTaskList().add(workflowTaskEntity);
-        serviceTask.initListeners(context);
-        this.taskEventNotifier.notify(TaskEvent.CREATE, context);
+        try {
+            serviceTask.initListeners(context);
+            this.taskEventNotifier.notify(TaskEvent.CREATE, context);
+        } catch (Exception e) {
+            e.printStackTrace();

Review Comment:
   done, check again



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org